Couple of fixes with handling multiple benchmarks data #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the benchmark menu was incorrectly hidden if there was only one benchmark for a commit. This commit changes the UI to hide the menu only when the benchmark is a "default" benchmark which is unnamed. When we have named benchmarks, we don't hide the menu because the GraphQL requests and ensure that the GraphQL request has the benchmark name in the request.
Previously, we only allowed unique test names for each benchmark run for a commit. But, we also allow multiple named benchmarks in each commit. This commit loosens the uniqueness restriction to allow duplicate test names in different benchmarks
|
Good catches! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of fixes for handling data of benchmark runs with multiple benchmarks. We support having a list of benchmarks, when each of them should be named.