Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check marks differ (minor) #17

Closed
jmid opened this issue Jul 5, 2023 · 3 comments
Closed

Check marks differ (minor) #17

jmid opened this issue Jul 5, 2023 · 3 comments

Comments

@jmid
Copy link
Contributor

jmid commented Jul 5, 2023

I've noticed that the check marks used to signal OK differs between the different backends tested.
The is obviously not a major issue - but nevertheless something that made my OCD click 😅

For example, for this PR ocaml-multicore/multicoretests#366
clicking Details on Multicoretests-CI yields the following under Linux Chromium:

checkmarks

https://github.com/ocaml-multicore/multicoretests/pull/366/checks?check_run_id=14737229131

Under Chrome on my old MacBook all OK marks are white-on-green, however the three green ones in the above screenshot are smaller, perhaps indicating a different Unicode character being used? 🤔

@benmandrew
Copy link
Collaborator

This issue has also appeared in OCaml-CI.

According to the HTML, GitHub seems to be injecting a wrapper <g-emoji> tag around some but not all emojis. If the emoji is deemed not to exist, it has a fallback (your white tick) but even if it finds the emoji it still modifies the appearance; you can see in your screenshot one of the red crosses is slightly larger than the others.

It's very annoying! Hopefully I'll find a quick fix.

@benmandrew
Copy link
Collaborator

This appears to have been a problem on GitHub's end that is now fixed. If it reappears the issue can be reopened.

@jmid
Copy link
Contributor Author

jmid commented Aug 16, 2023

I'm still seeing different checkmarks, so I think this should be reopened:

checkmarks-take2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants