Add macOS support #116
Merged
Add macOS support #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checklist for macOS CI: Critical:
Urgent but non-essential:
|
kit-ty-kate
force-pushed
the
macos
branch
2 times, most recently
from
bef0665
to
16fbf2c
Compare
6 tasks
kit-ty-kate
force-pushed
the
macos
branch
3 times, most recently
from
f4b861c
to
42a1e96
Compare
kit-ty-kate
force-pushed
the
macos
branch
4 times, most recently
from
eecd620
to
9ade54b
Compare
kit-ty-kate
commented
Jan 22, 2022
lib/opam_build.ml
Outdated
| @@ -44,7 +44,32 @@ let opam_install ~variant ~opam_version ~pin ~lower_bounds ~with_tests ~pkg = | |||
|
|
|||
| let setup_repository ~variant ~for_docker ~opam_version = | |||
| let open Obuilder_spec in | |||
| let home_dir = match Variant.os variant with | |||
| | `macOS -> "/Users/mac705" | |||
There was a problem hiding this comment.
Suggested change
| | `macOS -> "/Users/mac705" | |
| | `macOS -> "/Users/mac705" |
@patricoferris is that always the case?
kit-ty-kate
force-pushed
the
macos
branch
2 times, most recently
from
f911758
to
dc36136
Compare
kit-ty-kate
force-pushed
the
macos
branch
2 times, most recently
from
e2ffbd1
to
f825994
Compare
|
Keeping this PR around until all the things are fixed is becoming too costly in maintenance time. All the issues have their TODO comments so I think it’s good enough to merge this now and fix things later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft PR to visualize the remaining differences and test on a local instance first.
cc @patricoferris