Skip to content

Commit

Permalink
fix name None
Browse files Browse the repository at this point in the history
  • Loading branch information
dsavchenko committed May 14, 2023
1 parent 6d1af61 commit 5a26718
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions cdci_data_analysis/analysis/queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,18 @@ def _build_parameters_list(self,_list):
raise RuntimeError('Parameter type %s have duplicate name %s in the query %s',
p.__class__.__name__, p.name, self)
_l.append(p)
_names.append(p.name)
if p.name is not None:
_names.append(p.name)
else:
# TODO: what is p in this case?
_l.extend(p.to_list())
# parametertuple
pars = p.to_list()
for x in pars:
if x.name in _names:
raise RuntimeError('Parameter type %s have duplicate name %s in the query %s',

Check warning on line 134 in cdci_data_analysis/analysis/queries.py

View check run for this annotation

Codecov / codecov/patch

cdci_data_analysis/analysis/queries.py#L134

Added line #L134 was not covered by tests
p.__class__.__name__, p.name, self)

_l.extend(pars)
_names.extend([x.name for x in pars if x.name is not None])
return _l

def show_parameters_list(self):
Expand Down

0 comments on commit 5a26718

Please sign in to comment.