Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stray modal opening when clicking on news item #249

Open
volodymyrss opened this issue Apr 12, 2024 · 6 comments
Open

stray modal opening when clicking on news item #249

volodymyrss opened this issue Apr 12, 2024 · 6 comments
Assignees

Comments

@volodymyrss
Copy link
Member

previously, I ran some analysis. Now this happens when I just click on news item:

image

@burnout87
Copy link
Collaborator

So:

  • run an anlysis
  • checking the progress
  • at completion, close the modal window
  • opened a news item
    Correct? I tried this sequence but didn't succeed in reproducing the issue

@volodymyrss
Copy link
Member Author

And yet it happens sometimes, @burnout87 . There must be some issues with state management and race conditions. It would help to think about where it can go wrong in this case.

This sort of issues are not easy to reproduce. I suggest you try to run different requests and click on different things in different order.

@volodymyrss
Copy link
Member Author

related case I think

image

@burnout87 please to request different things and stop at different time to reproduce

@burnout87
Copy link
Collaborator

I tried to run multiple times different types of analysis, played around, but I really didn't manage to reproduce the issue when opening a news item.

In the meantime, with these two PRs more bugs should be fixed:

oda-hub/dispatcher-app#670
oda-hub/dispatcher-plugin-nb2workflow#100 (adaptation to the changes introduced in the dispatcher)

@burnout87
Copy link
Collaborator

previously, I ran some analysis. Now this happens when I just click on news item:

image

This is fixed with 584beaa

@burnout87
Copy link
Collaborator

burnout87 commented Apr 26, 2024

related case I think

image

I reproduced it locally, and I confirm this is fixed with f3ce11e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants