Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take default branch as 'reference' for VCS connection #148

Closed
BPylypenko opened this issue Mar 3, 2020 · 0 comments · Fixed by #402
Closed

take default branch as 'reference' for VCS connection #148

BPylypenko opened this issue Mar 3, 2020 · 0 comments · Fixed by #402
Assignees
@keshamin
Labels
1.4 feature [Added] for new features. WG:training Working group: All about model training functionality
Projects
odahu-kanban

Comments

@BPylypenko
Copy link
Contributor

BPylypenko commented Mar 3, 2020 •
edited
Loading

description
If no reference is indicated in VCS connection and training then the default branch of a repository should be taken.

when creating a connection, it is optional to specify the Reference field, and if you do not specify reference again when creating a model training, it returns an error to you:
MicrosoftTeams-image

desired behavior
if reference is not specified in VCS connection and training spec, then we take VCS default branch
@BPylypenko BPylypenko added the 1.1 label Mar 3, 2020
@BPylypenko BPylypenko added this to To do in odahu-kanban via automation Mar 3, 2020
@mcdoker18 mcdoker18 added 1.2 and removed 1.1 labels Mar 6, 2020
@mcdoker18 mcdoker18 added 1.3 and removed 1.2 labels Mar 17, 2020
@karbyshevds karbyshevds removed the 1.3 label Jul 20, 2020
@karbyshevds karbyshevds added the bug Something isn't working label Sep 22, 2020
@BPylypenko BPylypenko moved this from Backlog to In progress in odahu-kanban Sep 22, 2020
@BPylypenko BPylypenko removed their assignment Sep 24, 2020
@BPylypenko BPylypenko added 1.3 and removed WIP bug Something isn't working 1.3 labels Sep 24, 2020
@BPylypenko BPylypenko moved this from In development to To Do in odahu-kanban Sep 24, 2020
@vlad-tokarev vlad-tokarev added 1.4 and removed 1.3 labels Sep 25, 2020
@vlad-tokarev vlad-tokarev added feature [Added] for new features. WG:training Working group: All about model training functionality labels Sep 30, 2020
@keshamin keshamin mentioned this issue Oct 6, 2020
Merged
@keshamin keshamin moved this from To Do to In development in odahu-kanban Oct 6, 2020
odahu-kanban automation moved this from In development to In QA Oct 20, 2020
keshamin added a commit that referenced this issue Oct 20, 2020
@keshamin
[#148] Use default VCS branch if none provided in training/connection (…
a57361e 
…#402)

Before reference was optional for Training if only VCS connection does have default reference. Now it is optional anyway. If reference was not specified in neither VCS connection or training then default HEAD after cloning the repo is used.
@BPylypenko BPylypenko moved this from In QA to Done in odahu-kanban Oct 23, 2020
BPylypenko pushed a commit that referenced this issue Nov 16, 2020
@keshamin @BPylypenko
[#148] Use default VCS branch if none provided in training/connection (…
7e33ddf 
…#402)

Before reference was optional for Training if only VCS connection does have default reference. Now it is optional anyway. If reference was not specified in neither VCS connection or training then default HEAD after cloning the repo is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keshamin keshamin

Labels
1.4 feature [Added] for new features. WG:training Working group: All about model training functionality
Projects
odahu-kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#148] Use default VCS branch if none provided in training/connection odahu/odahu-flow
5 participants
@karbyshevds @mcdoker18 @keshamin @vlad-tokarev @BPylypenko