Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deployment/route CRD controllers to use Knative Service, not Configuration #347

Closed
keshamin opened this issue Sep 18, 2020 · 1 comment · Fixed by #505
Closed
Assignees
Labels
1.5 TechDebt WG:deployment Working Group: All about model deployment functionality

Comments

@keshamin
Copy link
Contributor

keshamin commented Sep 18, 2020

Currently to deploy a model:

  1. we create Knative Configuration to deploy a model
  2. we track if the Knative Revision is created and ready
  3. we create a K8s service for that revision
  4. we copy Endpoints from Knative Revision to our K8s Service
  5. we create an Istio VirtualService that routes requests from Istio Ingress to the corresponding K8s service.

This can be simplified as follows:

  1. we create Knative Service
  2. we wait for the Knative Service to get up and running
  3. we create an Istio VirtualService that routes requests from Istio Ingress to the Knative Service.

This guide demonstrates a simplified implementation: https://knative.dev/docs/serving/samples/knative-routing-go/index.html

@keshamin keshamin added TechDebt WG:deployment Working Group: All about model deployment functionality labels Sep 18, 2020
@keshamin keshamin added this to Backlog in odahu-kanban via automation Sep 18, 2020
@keshamin keshamin self-assigned this Oct 29, 2020
@vlad-tokarev
Copy link
Member

vlad-tokarev commented Oct 29, 2020

Knative manages Istio Ingress internally to turn traffic between Application pod svc and Knative Activator pod.
So in this case:

we create an Istio VirtualService that routes requests from Istio Ingress to the Knative Service.

We may face problems that this feature will conflict with Knative ingress managing

@karbyshevds karbyshevds moved this from Backlog to To Do in odahu-kanban Feb 12, 2021
@keshamin keshamin moved this from To Do to In development in odahu-kanban Feb 17, 2021
@keshamin keshamin moved this from In development to In QA in odahu-kanban Mar 12, 2021
@BPylypenko BPylypenko moved this from In QA to Done in odahu-kanban Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.5 TechDebt WG:deployment Working Group: All about model deployment functionality
Projects
odahu-kanban
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants