Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readinessProbe & livenessProbe InitialDelays should start from 0, not 1 #442

Closed
BPylypenko opened this issue Nov 28, 2020 · 0 comments · Fixed by #474
Closed

readinessProbe & livenessProbe InitialDelays should start from 0, not 1 #442

BPylypenko opened this issue Nov 28, 2020 · 0 comments · Fixed by #474
Assignees
Labels
1.4 bug Something isn't working WG:API Working Group: All about odahu api functionality WG:deployment Working Group: All about model deployment functionality

Comments

@BPylypenko
Copy link
Contributor

description
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes
There is written that the minimum value is 0, but we require to be it greater than 0
and improve the description of the errors.

specification
deployment_no_required_params.txt

to reproduce

  1. run odahuflowctl dep create -f deployment_no_required_params.txt

Expected behavior
the lowest intial delay should be 0 sec.
Error parts:

livenessProbeInitialDelay must be non-negative integer
readinessProbeInitialDelay must be non-negative integer

Actual behavior
the lowest intial delay is 1 sec.
Error parts:

liveness probe parameter must be positive number
readiness probe must be positive number

@BPylypenko BPylypenko added bug Something isn't working WG:API Working Group: All about odahu api functionality WG:deployment Working Group: All about model deployment functionality 1.4 labels Nov 28, 2020
@BPylypenko BPylypenko added this to Backlog in odahu-kanban via automation Nov 28, 2020
@BPylypenko BPylypenko moved this from Backlog to To Do in odahu-kanban Nov 28, 2020
@BPylypenko BPylypenko moved this from To Do to In development in odahu-kanban Jan 12, 2021
BPylypenko added a commit that referenced this issue Jan 19, 2021
BPylypenko added a commit that referenced this issue Jan 19, 2021
BPylypenko added a commit that referenced this issue Jan 20, 2021
@BPylypenko BPylypenko moved this from In development to In QA in odahu-kanban Jan 28, 2021
@BPylypenko BPylypenko moved this from In QA to Done in odahu-kanban Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.4 bug Something isn't working WG:API Working Group: All about odahu api functionality WG:deployment Working Group: All about model deployment functionality
Projects
odahu-kanban
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant