Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not masked keySecret or password during review of connection creation #42

Closed
BPylypenko opened this issue Sep 17, 2020 · 1 comment · Fixed by #49 or #68
Closed

not masked keySecret or password during review of connection creation #42

BPylypenko opened this issue Sep 17, 2020 · 1 comment · Fixed by #49 or #68
Assignees
@keshamin
Labels
1.4 bug Something isn't working normal minor functionality or non-critical data. It has an easy workaround. UI
Projects
odahu-kanban

Comments

@BPylypenko
Copy link
Contributor

BPylypenko commented Sep 17, 2020 •
edited
Loading

To Reproduce

  1. go to Connections panel
  2. press + New button
  3. fill in required fields and press NEXT
  4. on Specification page fill in the required fields and press NEXT

Expected behavior
you see maskes instead of actual values for Password or keySecret fields on REVIEW page

Actual behavior
you can see unmasked Password or keySecret fields on REVIEW page

Screenshots
MicrosoftTeams-image
@BPylypenko BPylypenko added 1.3 1.3 relese bug Something isn't working normal minor functionality or non-critical data. It has an easy workaround. labels Sep 17, 2020
@BPylypenko BPylypenko added this to Backlog in odahu-kanban via automation Sep 17, 2020
@vlad-tokarev vlad-tokarev moved this from Backlog to To Do in odahu-kanban Sep 23, 2020
@vlad-tokarev vlad-tokarev moved this from To Do to In progress in odahu-kanban Sep 24, 2020
@vlad-tokarev vlad-tokarev self-assigned this Sep 24, 2020
vlad-tokarev added a commit that referenced this issue Sep 24, 2020
@vlad-tokarev
not masked keySecret or password during review of connection creati…
acd1845 
…on [#42]
@vlad-tokarev vlad-tokarev mentioned this issue Sep 24, 2020
Merged
odahu-kanban automation moved this from In development to In QA Sep 25, 2020
vlad-tokarev added a commit that referenced this issue Sep 25, 2020
@vlad-tokarev
not masked keySecret or password during review of connection creati…
6ecef48 
…on [#42] (#49)
vlad-tokarev added a commit that referenced this issue Sep 29, 2020
@vlad-tokarev
not masked keySecret or password during review of connection creati…
972f7ed 
…on [#42] (#49)
@BPylypenko
Copy link
Contributor Author

As we mask access Key ID during type-in (on Specification tab), connection types: s3, ecr
image

I think we also should mask it during REVIEW:
image

@BPylypenko BPylypenko reopened this Oct 2, 2020
odahu-kanban automation moved this from In QA to To Do Oct 2, 2020
@karbyshevds karbyshevds added 1.4 and removed 1.3 1.3 relese labels Oct 6, 2020
@BPylypenko BPylypenko mentioned this issue Oct 20, 2020
Merged
@keshamin keshamin assigned keshamin and unassigned vlad-tokarev Oct 22, 2020
@vlad-tokarev vlad-tokarev mentioned this issue Oct 22, 2020
Merged
odahu-kanban automation moved this from To Do to In QA Oct 22, 2020
keshamin added a commit that referenced this issue Oct 22, 2020
@keshamin
[#42] Replce Key ID by hiddenSequence in ERC and S3 view (#68)
a47ba32 
Co-authored-by: Innokentii Min <innokentii_min@epam.com>
@BPylypenko BPylypenko moved this from In QA to Done in odahu-kanban Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keshamin keshamin

Labels
1.4 bug Something isn't working normal minor functionality or non-critical data. It has an easy workaround. UI
Projects
odahu-kanban
  
Done
Milestone
No milestone
4 participants
@karbyshevds @keshamin @vlad-tokarev @BPylypenko