Add popup categories and contacts #29
Conversation
SergSkol
commented
Dec 1, 2022
SergSkol
commented
- Add categories popup window;
- Add contacts popup window;
| try { | ||
| const data = await response.json(); | ||
| const commentsCount = document.getElementById(`comment${id}`); | ||
| commentsCount.textContent = `${data.length || ''}`; | ||
| } catch (err) { |
There was a problem hiding this comment.
good job 👍, that you created a counter for comments and it's not mandatory or from the requirements of the project, but kindly check it again because it's not working as supposed. 😃 [optional]
There was a problem hiding this comment.
I can't catch fetch response with status 400 in case if there are no comments for specific ID. So, I'm going to remove this part of code for a while.
src/style.css
Outdated
|
|
||
| .cat-popup { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| position: fixed; | ||
| top: 10px; | ||
| left: 10px; | ||
| background-color: white; | ||
| border: 4px solid #3e3e3e; | ||
| overflow-y: scroll; | ||
| height: 100%; | ||
| z-index: 999; | ||
| padding: 0 32px 0 32px; | ||
| } | ||
|
|
There was a problem hiding this comment.
good job 👍, that you created a category popup it's not mandatory or from the requirements of the project, I suggest adding more style for it to make it look great and more organized. 😃 [optional]
There was a problem hiding this comment.
Status: ✔️ Project Approved ✔️ 🕺🥳
Congratulations🍾🥳!! Your project is ready! There is nothing else to say other than... it's time to merge it 
Highlights
- Implemented all the requirements .👏 ✔️
- implemented extra requirements like a comment counter and category page. 🙌👏
Optional Suggestions:
kindly consider the comment with the [optional] word, it will help you to improve your project and make it look better.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @odaialazzeh in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
