Init

odan · Nov 8, 2023 · f044983 · f044983
1 parent 94baeb2
commit f044983
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -16,6 +16,8 @@ Extreme fast in-memory Excel (XLSX) file writer.
 - Multiple sheets in a workbook.
 - Header columns with bold font.
 - Custom worksheet name.
+- Data types for rows: string, int, float
+- Data types for columns: string
 
 ## Limitations
 
@@ -52,13 +54,13 @@ $sheet->addColumns($columns);
 
 // Write data
 $rows = [
-    ['2023-01-31', 'James', '220'],
-    ['2023-03-28', 'Mike', '153.5'],
-    ['2024-07-02', 'John', '34.12'],
+    ['2023-01-31', 'James', 220],
+    ['2023-03-28', 'Mike', 153.5],
+    ['2024-07-02', 'Sally', 34.12],
 ];
 
 foreach ($rows as $row) {
-    $sheet->writeRow($row);
+    $sheet->addRow($row);
 }
 
 // Save as Excel file

diff --git a/src/ExcelWorksheet.php b/src/ExcelWorksheet.php
@@ -67,9 +67,17 @@ public function addRow(array $values): void
 
             // s = 0 = Normal font (see styles.xml)
             $column->setAttribute('s', '0');
-            $column->setAttribute('t', 's');
-            $sharedStringIndex = $this->sharedStrings->add($value);
-            $valueNode = $this->sheetXml->createElement('v', (string)$sharedStringIndex);
+
+            // Detect numeric types (not values)
+            if (is_int($value) || is_float($value)) {
+                $column->setAttribute('t', 'n');
+                $valueNode = $this->sheetXml->createElement('v', (string)$value);
+            } else {
+                $column->setAttribute('t', 's');
+                $sharedStringIndex = $this->sharedStrings->add((string)$value);
+                $valueNode = $this->sheetXml->createElement('v', (string)$sharedStringIndex);
+            }
+
             $column->appendChild($valueNode);
         }
     }

diff --git a/tests/ExcelWriterTest.php b/tests/ExcelWriterTest.php
@@ -38,9 +38,9 @@ public function test(): void
         $sheet2->addColumns($columns);
 
         $data = [
-            ['2023-12-31', 'Max', '220', '0.1'],
-            ['2023-8-23', 'John', '1234.5', '0.3'],
-            ['2023-06-01', 'Daniel', '6789.12', '1.4'],
+            ['2023-12-31', 'Max', '220', 0.1],
+            ['2023-8-23', 'John', '1234.5', 0.3],
+            ['2023-06-01', 'Daniel', '6789.12', 1.4],
         ];
 
         // Write data