Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-kms-provider): provide endpoint argument #625

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jul 25, 2022

This pull request introduces also endpoint argument to use specific endpoint manually.

@coveralls
Copy link

coveralls commented Jul 25, 2022

Pull Request Test Coverage Report for Build 2730461664

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.0%

Totals Coverage Status
Change from base Build 2635630682: 0.0%
Covered Lines: 118
Relevant Lines: 131

💛 - Coveralls

Copy link
Owner

@odanado odanado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM

@odanado
Copy link
Owner

odanado commented Aug 12, 2022

@moreal
BTW, aws-kms-provider has been rewrite into @cloud-cryptographic-wallet/web3-provider-adapter and @cloud-cryptographic-wallet/aws-kms-signer.
I recommend switching to this libraries if possible.

https://github.com/odanado/cloud-cryptographic-wallet/blob/master/packages/web3-provider-adapter/README.md

@odanado
Copy link
Owner

odanado commented Aug 12, 2022

I'm working on resolving the GitHub Actions error.
It will be a while before I can merge the pull requests and publish the library.

@odanado
Copy link
Owner

odanado commented Aug 18, 2022

I ran the e2e test locally and confirmed it succeeded.

$ AWS_PROFILE=root RPC_URL=http://localhost:8501 yarn e2e
 ✓ packages/asn1-parser/src/parse-public-key.spec.ts (2)
 ✓ packages/asn1-parser/src/parse-signature.spec.ts (3)
 ✓ test/e2e/ethers/send-eth.spec.ts (2) 2509ms
 ✓ test/e2e/legacy/ethers-send-eth.spec.ts (1) 2449ms
 ✓ test/e2e/legacy/web3-send-eth.spec.ts (1) 1685ms
 ✓ test/e2e/legacy/web3-sign.spec.ts (1) 902ms
 ✓ test/e2e/web3/send-eth.spec.ts (2) 2132ms

Test Files  7 passed (7)
     Tests  12 passed (12)
      Time  10.82s (in thread 9.69s, 111.65%)

@odanado odanado merged commit 579fa88 into odanado:master Aug 18, 2022
@odanado
Copy link
Owner

odanado commented Aug 18, 2022

@moreal
This change was released in aws-kms-provider@0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants