Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve method name on @Transactional method overwrite #16

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

labibramadhan
Copy link
Contributor

While using @transactional that overwriting controller method, preserve the method name for being used later by the @nestjs/swagger for exploring @Body(), @param(), and @query() metadata

While using @transactional that overwriting controller method, preserve the method name for being used later by the @nestjs/swagger for exploring @Body(), @param(), and @query() metadata
@labibramadhan
Copy link
Contributor Author

This is the fix for #15

@odavid
Copy link
Owner

odavid commented Apr 26, 2019

@labibramadhan - Thank you, and sorry it took me some time.
I still think it is not a bug in this decorator, but I do understand the need for it.
Cheers

Aliheym referenced this pull request in Aliheym/typeorm-transactional Jul 31, 2022
* Preserve method name on @transactional method overwrite

While using @transactional that overwriting controller method, preserve the method name for being used later by the @nestjs/swagger for exploring @Body(), @param(), and @query() metadata

* Redefine metadata to the descriptor.value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants