Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post on un-mixing a mixin #614

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Blog post on un-mixing a mixin #614

merged 10 commits into from
Jun 11, 2024

Conversation

mirisuzanne
Copy link
Member

@mirisuzanne mirisuzanne commented Jun 9, 2024

Description

Something I was thinking about after CSS Day
https://deploy-preview-614--oddleventy.netlify.app/2024/06/11/removing-mixins/

Related Issue(s)

Should I make more mention of CSS Day, or my role there, or the workshop (somehow?)

Copy link

github-actions bot commented Jun 9, 2024

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..un-mixing

content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
Co-authored-by: david herron <41588129+dvdherron@users.noreply.github.com>
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an image, but otherwise LGTM 👍

content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Copy link
Contributor

@SondraE SondraE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Roma Komarov should be Roman throughout the article? That's what's on their website when you click through, anyhow.

I don't think "off-switch" needs a hyphen?

You end the article with questions. You could add something like: come discuss this with me at the upcoming Cascading Layout Workshop on June 24. You can register below.
Additionally you could put the registration form CTA near the beginning of the article with an invitation something like: If you have questions about all this, come ask them. I'll be doing live Q&A at the Cascade Layouts Workshop June 24-26.

@mirisuzanne
Copy link
Member Author

Should Roma Komarov should be Roman throughout the article? That's what's on their website when you click through, anyhow.

We could. He uses Roma on Mastodon - just the short form of the name. I think either is fine if we're consistent?

You end the article with questions. You could add something like: come discuss this with me at the upcoming Cascading Layout Workshop on June 24. You can register below.
Additionally you could put the registration form CTA near the beginning of the article with an invitation something like: If you have questions about all this, come ask them. I'll be doing live Q&A at the Cascade Layouts Workshop June 24-26.

Does it matter that it's a layout workshop, and this post isn't really layout related at all?

Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great article. Great examples in it as well. Approving but I don't think it has a hero image yet?

content/blog/2024/removing-mixins.md Outdated Show resolved Hide resolved
) }}


## It's hard to un-mix a previously mixed-in mixin once mixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great heading

mirisuzanne and others added 6 commits June 11, 2024 02:30
Co-authored-by: Stacy Kvernmo <stacyk@users.noreply.github.com>
* main:
  Update content/blog/elsewhere/interview/podcast/mechanical-ink.md
  Apply suggestions from code review
  Add Mechanical Ink podcast
  Bump the npm-minor-upgrades group with 5 updates
  Bump @rollup/plugin-commonjs in the npm-major-upgrades group
  Automated webmentions update
@SondraE SondraE merged commit b1b5338 into main Jun 11, 2024
10 checks passed
@SondraE SondraE deleted the un-mixing branch June 11, 2024 16:54
@mirisuzanne
Copy link
Member Author

@SondraE
Copy link
Contributor

SondraE commented Jun 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Mixins video and/or post
5 participants