Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration fallback link #627

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Add registration fallback link #627

merged 2 commits into from
Jun 13, 2024

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Jun 13, 2024

Description

Adds a fallback registration link until the Tito Widget is fully loaded.

Steps to test/reproduce

  1. Go to Registration page - https://deploy-preview-627--oddleventy.netlify.app/workshops/cascading-layouts/
  2. Enable Throttling in your Network dev tools
  3. Load the registration page, see there is a Registration link that gets removed once the widget is fully loaded.

@jamesnw jamesnw requested a review from mirisuzanne June 13, 2024 14:47
Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..registration-fallback

Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
@jamesnw jamesnw merged commit 688f636 into main Jun 13, 2024
9 of 10 checks passed
@jamesnw jamesnw deleted the registration-fallback branch June 13, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants