Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filter-in-page] Add basic in-page filter #195

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

wlonk
Copy link
Contributor

@wlonk wlonk commented Nov 16, 2017

Fixes #52.

antelope

@jgerigmeyer jgerigmeyer changed the title Add basic in-page filter [filter-in-page] Add basic in-page filter Nov 17, 2017
* master:
  review cleanup
  Cleanup fonts/scale docs & previews
  Cleanup font docs
  100% test coverage because why not
  Address review comments.
  Add example to njk examples doc
  Add use-cases to relevant config
  Update page titles.
  Add doc notes re: customCSS gotchas
  Initial annotation docs.
  Complete coverage for annotations.example
  Add coverage for annotations.font
  Add linting fixes
  Add coverage for colors Nunjucks filter
  Complete test coverage for parse
@wlonk
Copy link
Contributor Author

wlonk commented Dec 11, 2017

I'm getting very different coverage numbers locally. @jgerigmeyer or someone, can you reproduce this?

* master:
  report to coveralls before checking coverage
@jgerigmeyer
Copy link
Member

@wlonk I'm seeing the same thing locally. Coverage is for both gulp jstests and gulp clienttests. Src JS has 100% coverage, but client JS only has ~95% coverage.

In any case, I think this branch should wait until we get more input on #52.

@wlonk
Copy link
Contributor Author

wlonk commented Dec 12, 2017

@jgerigmeyer Ah, gotcha. I see it now.

And yeah, let's get input on #52. This can wait.

@jgerigmeyer jgerigmeyer changed the base branch from master to main January 4, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add real time search/filter
2 participants