Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libsass #406

Merged
merged 28 commits into from Jan 14, 2015
Merged

Libsass #406

merged 28 commits into from Jan 14, 2015

Conversation

mirisuzanne
Copy link
Member

No description provided.

@samusgray
Copy link
Collaborator

Wooo! eagerly refreshing to check Travis CI build

@mirisuzanne
Copy link
Member Author

why wait? bower install susy#2.2.0.beta.2 and give it a test of your own!

@christianmagill
Copy link

Nice!

Is there any specific version of libsass we need to use. I ran a npm update on gulp-sass and node-sass and i get:

grid:6: error: error reading values after columns

Which is right at the start of my Susy config map.

Much thanks for all your work!

@mirisuzanne
Copy link
Member Author

@christianmagill interesting. I was working off the master branches of libsass and sassc — maybe node-sass and gulp-sass aren't up-to-date? I thought they had merged in map support by now.

@mirisuzanne
Copy link
Member Author

Looks like node-sass (and gulp-sass by association) are still using an older version of libsass. Hopefully we can get them to release updates asap.

@christianmagill
Copy link

Thanks! Super excited.
On Fri, Nov 28, 2014 at 4:24 PM Eric M. Suzanne notifications@github.com
wrote:

Looks like node-sass (and gulp-sass by association) are still using an
older version of libsass. Hopefully we can get them to release updates asap.


Reply to this email directly or view it on GitHub
#406 (comment).

@lmartins
Copy link

@christianmagill you can try npm install gulp-sass@beta, not sure if it already have the needed features though.

@christianmagill
Copy link

Thanks, that did the trick

@vongoh
Copy link

vongoh commented Dec 29, 2014

Hi - as I am newbish on Grunt and am super excited to see Susy working (lighting fast!) in libsass .. is this beta now working with grunt-sass and how do I try it out!? (it is post Xmas - pre NewYears, do not know where u are all at with this!)

@mirisuzanne
Copy link
Member Author

Everything should be working on the latest versions of grunt-sass, and the RC of Susy. You can install with bower (or npm now), or download the files directly wherever you need them. We'll get this officially merged and launched real soon, if everything goes smoothly.

@vongoh
Copy link

vongoh commented Jan 5, 2015

.. the RC of Susy - You can install with bower (or npm now), or download the files directly

Sorry, when I said I am 'newbish' with Grunt I'm not kidding - I literally spent the past couple of weeks doing nothing but learning Grunt (and GIt) in preparation to move my whole setup to the command line .. just to be able to try running Susy with Libsass :) My compile times with Prepros and Susy have been close to 10 secs .. so I have been looking forward to this for months!

Do I npm install [SUSY RC COMMAND HERE] --save-dev? I tried installing something with bower but that did not work out. Can someone give me a clear set of commands to get this running to test it?

I will be glad to report any issues / bug I find, to help out .. thanks!

@samusgray
Copy link
Collaborator

Hey @vongoh,

Do you have bower installed? If so, you can try these steps out here. #415 Just be sure to cd into your project directory before you run these commands.

Please let me know fi they work for you.

@vongoh
Copy link

vongoh commented Jan 5, 2015

@aaronagray -- Thanks! That did the trick, I'm up and running - most appreciated. This is lighting fast, it rocks!

I am already noticing a few oddities however. Where is the best place to report them, here? Or on the libsass repo - or are you splitting the reporting based on the nature of the issue, thx

@samusgray
Copy link
Collaborator

Feel free to submit a new issues. Just be sure to give it a reasonable title and help us identify how to reproduce it in the issue body. Also, any error logs our unexpected output you get is helpful.

@stevetweeddale stevetweeddale mentioned this pull request Jan 8, 2015
@steveax
Copy link

steveax commented Jan 14, 2015

Got this to work with an ember-cli project, here's my setup:

Using this branch of susy in my bower.json: "susy": "libsass"

Using the 3.1.0-beta tag of ember-cli-sass

which pulls in the sources-content branch of Simon's fork of broccoli-sass

which pulls in node-sass 2.0.0-beta

which includes libsass 3.1.0-alpha

So, seems good once all the bits are finalized! Thanks for all the work :-)

steveax referenced this pull request in adopted-ember-addons/ember-cli-sass Jan 14, 2015
@samusgray
Copy link
Collaborator

@steveax Thanks for testing this in Ember. That's great to hear.

samusgray added a commit that referenced this pull request Jan 14, 2015
@samusgray samusgray merged commit 1eeb1ad into master Jan 14, 2015
@samusgray samusgray deleted the libsass branch January 14, 2015 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants