Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated use of node assert.fail #141

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Fix deprecated use of node assert.fail #141

merged 3 commits into from
Mar 8, 2019

Conversation

jgerigmeyer
Copy link
Member

Fixes #138.

jgerigmeyer
jgerigmeyer commented Mar 8, 2019
View reviewed changes
package.json
"css": "^2.2.1",
"css-selector-parser": "^1.1.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne I didn't see this being used anywhere? Am I missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may be left over from the original way we handled test-result parsing with selectors rather than comments?

@jgerigmeyer jgerigmeyer mentioned this pull request Mar 8, 2019
Closed
@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited

Pull Request Test Coverage Report for Build 427

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 422: 0.0%
Covered Lines: 279
Relevant Lines: 279
💛 - Coveralls

mirisuzanne
mirisuzanne approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@mirisuzanne mirisuzanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jgerigmeyer jgerigmeyer merged commit 3a4c8a7 into master Mar 8, 2019
@jgerigmeyer jgerigmeyer deleted the fix-deprecated-assertion branch March 8, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirisuzanne mirisuzanne mirisuzanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgerigmeyer @coveralls @mirisuzanne