Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change implementation initializeSDK #126

Merged
merged 1 commit into from Aug 18, 2021
Merged

Change implementation initializeSDK #126

merged 1 commit into from Aug 18, 2021

Conversation

DennisAlund
Copy link
Member

@DennisAlund DennisAlund commented Aug 13, 2021 •
edited

Fixes #125

bhanuka96
bhanuka96 approved these changes Aug 14, 2021
View reviewed changes
Copy link

@bhanuka96 bhanuka96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DennisAlund
Copy link
Member Author

Apologies for delay. We're having compilation errors on our side, that seems to be isolated to MacBooks with M1 chip... so I will merge this PR and make a release and see if we can find a solution from our side or the community if it turns out it's a M1 chip issue.

@DennisAlund DennisAlund merged commit d809e2d into master Aug 18, 2021
@DennisAlund DennisAlund mentioned this pull request Aug 18, 2021
Closed
@DennisAlund DennisAlund deleted the issue/125-error-instance-member-initializeSDK branch November 1, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-balas g-balas g-balas approved these changes

@bhanuka96 bhanuka96 bhanuka96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS error compilation version facebook_app_events: ^0.13.1
4 participants
@DennisAlund @g-balas @bhanuka96 @suryaoddbit