-
Notifications
You must be signed in to change notification settings - Fork 15
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OR condition #10
Comments
Yes it's on my list for version 2.0 which will also be JSON API compliant. I am not sure how the API for #or will look like (maybe like you suggest) but it will exploit rails 5 AR #OR method. Probably it will land around December unless you want to send a pull request :) |
Great Lib! Thnx! I've been trying to implement or-filters, here is my result so far:
It is to be called as suggested: One thing I don't understand is why I have to overwrite the Didn't test well yet, but it might be a good start. |
Thanks for the feedback @KRaymundus. As I said, I am adding tests at the moment in order to move faster without breaking anything and include features such as this one. I will probably finish adding tests end of this week and I will ping you then so we can take a look on your feedback and merge to master. |
@RafaelMCarvalho @KRaymundus thank you for your input. The |
Would be nice to have something like:
What do you think?
The text was updated successfully, but these errors were encountered: