Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bedtime messages are spamming the chat #127

Closed
oddlama opened this issue Feb 4, 2022 · 6 comments
Closed

bedtime messages are spamming the chat #127

oddlama opened this issue Feb 4, 2022 · 6 comments
Labels
improvement Improvement to existing feature or mechanic

Comments

@oddlama
Copy link
Owner

oddlama commented Feb 4, 2022

We could make those into action-bar messages that get displayed for players in the relevant world. Thoughts?

@oddlama oddlama added the improvement Improvement to existing feature or mechanic label Feb 4, 2022
@ryantheleach
Copy link
Contributor

Actionbar is what I would recommend, only problem is that vanilla also uses the action bar for bed related stuff.

Care is needed in testing to make sure that it doesn't obliterate the vanilla messages, without adding to it.

@oddlama
Copy link
Owner Author

oddlama commented Feb 4, 2022

I can currently only remember "bed too far away", "monsters nearby" and "too far away" messages. are there any messages while sleeping?

@ryantheleach
Copy link
Contributor

ryantheleach commented Feb 4, 2022

1.17 introduces gamerules surrounding % based player sleep voting. /gamerule playersSleepingPercentage 50

These messages are communicated via the action bars.

image

@oddlama
Copy link
Owner Author

oddlama commented Feb 4, 2022

Ahh true! That almost makes the plugin obsolete haha

@oddlama
Copy link
Owner Author

oddlama commented Feb 4, 2022

Do you know if it displays current sleepers/required sleepers or current sleepers/players in world? Haven't got enough people at hand to test it myself.

@oddlama
Copy link
Owner Author

oddlama commented Feb 4, 2022

I'd probably just send an action message when a player enters the bed, overriding the vanilla message.
It would be broadcast to the action bar of all players in the relevant world and display:

<player> is sleeping <n_sleeping>/<n_required>

@ryantheleach Any objections?

P.S.: And I will remove the success message i guess, because it's unnecessary.

@oddlama oddlama closed this as completed in 820a6e8 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing feature or mechanic
Projects
None yet
Development

No branches or pull requests

2 participants