Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support Barrels in Chest Sorting #31

Closed
fallsimply opened this issue Aug 7, 2021 · 1 comment
Closed

Feature: Support Barrels in Chest Sorting #31

fallsimply opened this issue Aug 7, 2021 · 1 comment
Labels
feature New feature or request

Comments

@fallsimply
Copy link

The chest sorting system doesn't currently work with barrels and barrels have a couple of advantages over chests.

Luckily the api for the chest and barrel is identical except for the getBlockInventory() method which is not being used. The casting may be an issue but if you make the sort_chest() method generic and pass the Chest or Barrel type

@oddlama
Copy link
Owner

oddlama commented Aug 8, 2021

Thanks for the suggestion, I can definitely implement this in the next update.

The casting shouldn't be an issue, as I am only using the Container and the BlockState interfaces, which both of them implement anyways. There will always be the special code for double chests, but this shouldn't be a problem either.

I'll leave this open until I get around to do some coding.

@oddlama oddlama added the feature New feature or request label Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants