Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private file info rather than view on IPFS #51

Closed
bmann opened this issue Aug 31, 2022 · 5 comments
Closed

Private file info rather than view on IPFS #51

bmann opened this issue Aug 31, 2022 · 5 comments
Assignees
Milestone

Comments

@bmann
Copy link

bmann commented Aug 31, 2022

Remove the "view on IPFS" link for private files / photos.

Maybe an "I" for info button with a short note "private files can only be viewed on other devices. Follow private file sharing (link to GitHub issue here)"

@avivash avivash self-assigned this Oct 13, 2022
@jeffgca jeffgca added this to the 0.3 Alpha 3 milestone Oct 18, 2022
@walkah walkah modified the milestone: 0.3 Alpha 3 Nov 15, 2022
@avivash
Copy link
Member

avivash commented Nov 15, 2022

@depatchedmode flagging this for the design team as there may be some specific design considerations we want to implement to show users that this is a feature/benefit of WNFS. Otherwise, i can implement a simple tooltip, as suggested in the issue description 👍🏼

@depatchedmode
Copy link

I'm actually tempted to leave the "view on IPFS" link in there, with a supporting explanation. I think it's more instructional in the sense that it provides evidence of the fact your data is encrypted. Because this sample Photos gallery in the WAT is meant to be a learning resource for developers, I think we should just be explicit and up front.

Something like this:
image

@avivash
Copy link
Member

avivash commented Nov 18, 2022

I'm actually tempted to leave the "view on IPFS" link in there, with a supporting explanation. I think it's more instructional in the sense that it provides evidence of the fact your data is encrypted. Because this sample Photos gallery in the WAT is meant to be a learning resource for developers, I think we should just be explicit and up front.

Something like this: image

Nice! I like that idea 👍🏼

@avivash
Copy link
Member

avivash commented Nov 21, 2022

This has been PRd against the two WAT repos. I'm working on a different spike for the rest of this week, but will implement this in the two WalletAuth repos ASAP 👍🏼

@avivash
Copy link
Member

avivash commented Jan 3, 2023

This has been implemented in the WalletAuth repos, as well

@bgins bgins closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants