Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: switch 'connect additional device' link to use goto #126

Merged

Conversation

avivash
Copy link
Member

@avivash avivash commented Apr 26, 2023

Description

Updating the href="/delegate-account" links in the app to use goto instead. For some reason using href to go to the delegated-account page creates some issues while device linking. Will have to dig further into that

Link to issue

#125

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Screenshots/Screencaps

https://www.loom.com/share/d1ddf7ca6cfc440cb622a7487aeb480f

@avivash avivash self-assigned this Apr 26, 2023
@avivash avivash marked this pull request as ready for review April 26, 2023 21:59
Copy link
Member

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

@avivash
Copy link
Member Author

avivash commented Apr 27, 2023

Seems the vercel deployments aren't working for the OAT app PR branches(though they still work for main merges). Trying to figure that out so we can get the playwright tests to pass. Will merge this once i've got that sorted 👍🏼

@avivash avivash closed this Apr 27, 2023
@avivash avivash reopened this Apr 27, 2023
@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
odd-app-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 5:16pm

@avivash avivash merged commit 1457d6b into main Apr 27, 2023
3 checks passed
@avivash avivash deleted the avivash/switch-connect-additional-device-links-to-use-goto branch April 27, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants