Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert in tests #540

Closed
bgins opened this issue Jul 28, 2023 · 1 comment
Closed

Use assert in tests #540

bgins opened this issue Jul 28, 2023 · 1 comment
Assignees
@bgins
Labels
enhancement New feature or request

Comments

@bgins
Copy link
Member

bgins commented Jul 28, 2023

Summary

Problem

We would like to run our unit tests in a headless browser, but expect uses node APIs that make this difficult.

Impact

No running unit tests in headless browsers.

Solution

Replace expect with assert: https://www.npmjs.com/package/assert
@bgins bgins added the enhancement New feature or request label Jul 28, 2023
@bgins bgins self-assigned this Jul 28, 2023
@bgins bgins mentioned this issue Jul 28, 2023
Merged
3 tasks
@bgins
Copy link
Member Author

bgins commented Jul 31, 2023

Closed by #541

@bgins bgins closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgins bgins

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bgins