Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace expect with assert #541

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Replace expect with assert #541

merged 2 commits into from
Jul 31, 2023

Conversation

bgins
Copy link
Member

@bgins bgins commented Jul 28, 2023

Summary

This PR implements the following features:

  • Replace expect with assert

The PR replaces expect with assert to make browser testing easier. expect relies on node APIs while assert does not.

We will add browser testing in a future PR.

Test plan (required)

Run npm test. All tests should pass like before.

Closing issues

Closes #540

After Merge

  • Does this change invalidate any docs or tutorials? No
  • Does this change require a release to be made? No

Expect relies on node APIs that make it difficult to do browser testing.
We will add browser testing in an upcoming PR.
@bgins bgins added the no changelog Attached to PRs which shouldn't require changelog changes label Jul 28, 2023
Copy link
Contributor

@icidasset icidasset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgins bgins merged commit c717b19 into next Jul 31, 2023
@bgins bgins deleted the bgins/use-assert branch July 31, 2023 16:54
@bgins bgins mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Attached to PRs which shouldn't require changelog changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants