Skip to content

Commit

Permalink
Merge pull request #16 from odeimaiz/pcrespov-is90/dockerfile-user
Browse files Browse the repository at this point in the history
fixes webserver dockerfile

* fixes healthcheck call
* webclient service does not restart now
* added rabbit dependencies to web server
  • Loading branch information
pcrespov committed Feb 18, 2019
2 parents 8263942 + 41de425 commit e7aa29d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
7 changes: 5 additions & 2 deletions services/docker-compose.yml
Expand Up @@ -74,6 +74,7 @@ services:
#--------------------------------------------------------------------
webclient:
image: services_webclient:build
restart: on-failure
build:
context: ./web/client/
dockerfile: Dockerfile
Expand All @@ -91,7 +92,9 @@ services:
- VCS_REF=${VCS_REF}
- VCS_REF_CLIENT=${VCS_REF_CLIENT}
- VCS_STATUS_CLIENT=${VCS_STATUS_CLIENT}
command: /bin/bash -c "echo 'built with qx' && cat build-output/version.txt"
command: >
/bin/sh -c "ls -l build-output;cat build-output/version.txt"
webserver:
image: ${DOCKER_IMAGE_PREFIX}webserver:${DOCKER_IMAGE_TAG}
build:
Expand Down Expand Up @@ -136,10 +139,10 @@ services:
stdin_open: true
tty: true
depends_on:
- webclient
- apihub
- postgres
- minio
- rabbit
deploy:
placement:
constraints:
Expand Down
2 changes: 1 addition & 1 deletion services/web/Dockerfile
Expand Up @@ -117,7 +117,7 @@ HEALTHCHECK --interval=30s \
--timeout=120s \
--start-period=30s \
--retries=3 \
CMD ["python3", "$HOME/services/web/server/docker/healthcheck.py", "http://localhost:8080"]
CMD ["python3", "/home/scu/services/web/server/docker/healthcheck.py", "http://localhost:8080/v0/"]

ENTRYPOINT [ "/bin/sh", "services/web/server/docker/entrypoint.sh" ]
CMD ["/bin/sh", "services/web/server/docker/boot.sh"]
Expand Down
1 change: 1 addition & 0 deletions services/web/client/Makefile
Expand Up @@ -37,6 +37,7 @@ build:
.PHONY: clean
# target: clean: – Cleans images and current dir outputs
clean:
@docker-compose down
@docker image rm -f client_qx:build 2> /dev/null
@docker image rm -f client_qx:development 2> /dev/null
@git clean -dxf ${CURDIR}
Expand Down

0 comments on commit e7aa29d

Please sign in to comment.