edit-desc: fix error handling to get proper return code #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch improves error handling of EditDescription. drive edit-desc returned 0 in some cases, like "remote path doesn't exist".
|
Hello there @thiell, thank you for the patch and welcome to drive! LGTM! Good stuff. |
odeke-em
pushed a commit
that referenced
this pull request
Mar 19, 2016
edit-desc: fix error handling to get proper return code
|
Hi @odeke-em - great, that was fast! Thank You! |
|
Hehe, I happened to be by computer. Good catch btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves error handling in EditDescription.
drive edit-desc returned 0 in some cases, like "remote path doesn't exist".
Fix the following issue where rc=0:
With this patch, rc=1 instead.