feat(elasticsearch): remove hard-coded port 9200, validate URL input #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
clavinjune
changed the title
blumamir
reviewed
Feb 4, 2024
…instead and validate scheme & host, add more test cases Signed-off-by: clavinjune <24659468+clavinjune@users.noreply.github.com>
blumamir
approved these changes
Feb 5, 2024
|
please help to merge if all's good since I don't have any write access 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables a flexible ES endpoints by removing hard-coded ES port in the endpoints section. This PR also sanitize/validate whether user input a valid URL or not by utilizing
url.Parse. I'm wondering whether we do need to have a test or not sinceurl.Parsefunction already have their own testPlease advise if we need more test cases
This PR will close #940