Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add npm install before npm build #964

Merged
merged 2 commits into from
Feb 11, 2024
Merged

add npm install before npm build #964

merged 2 commits into from
Feb 11, 2024

Conversation

tomasmota
Copy link
Contributor

if npm run build is run before npm install, next is not available:
image

@tomasmota tomasmota requested a review from a team as a code owner February 10, 2024 15:43
@tomasmota tomasmota closed this Feb 10, 2024
@tomasmota tomasmota deleted the patch-1 branch February 10, 2024 15:53
@tomasmota tomasmota restored the patch-1 branch February 10, 2024 16:51
@tomasmota tomasmota reopened this Feb 10, 2024
alonkeyval
alonkeyval approved these changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@alonkeyval alonkeyval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blumamir blumamir merged commit 2c745bc into odigos-io:main Feb 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonkeyval alonkeyval alonkeyval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomasmota @alonkeyval @blumamir