phpstan fixes

odiseoteam · Nov 28, 2019 · 9d11456 · 9d11456
1 parent 87b6c26
commit 9d11456
Show file tree

Hide file tree

Showing 15 changed files with 24 additions and 56 deletions.
diff --git a/src/Api/EcommerceInterface.php b/src/Api/EcommerceInterface.php
@@ -8,177 +8,146 @@ interface EcommerceInterface
 {
     /**
      * @param array $data
-     * @return array|false
      */
     public function addStore(array $data);
 
-    /**
-     * @return array|false
-     */
     public function getStores();
 
     /**
      * @param string $storeId
-     * @return array|false
      */
     public function getStore(string $storeId);
 
     /**
      * @param string $storeId
      * @param array $data
-     * @return array|false
      */
     public function updateStore(string $storeId, array $data);
 
     /**
      * @param string $storeId
-     * @return array|false
      */
     public function removeStore(string $storeId);
 
     /**
      * @param string $storeId
      * @param array $data
-     * @return array|false
      */
     public function addCustomer(string $storeId, array $data);
 
     /**
      * @param string $storeId
-     * @return array|false
      */
     public function getCustomers(string $storeId);
 
     /**
      * @param string $storeId
      * @param string $customerId
-     * @return array|false
      */
     public function getCustomer(string $storeId, string $customerId);
 
     /**
      * @param string $storeId
      * @param string $customerId
      * @param array $data
-     * @return array|false
      */
     public function updateCustomer(string $storeId, string $customerId, array $data);
 
     /**
      * @param string $storeId
      * @param string $customerId
-     * @return array|false
      */
     public function removeCustomer(string $storeId, string $customerId);
 
     /**
      * @param string $storeId
      * @param array $data
-     * @return array|false
      */
     public function addProduct(string $storeId, array $data);
 
     /**
      * @param string $storeId
-     * @return array|false
      */
     public function getProducts(string $storeId);
 
     /**
      * @param string $storeId
      * @param string $productId
-     * @return array|false
      */
     public function getProduct(string $storeId, string $productId);
 
     /**
      * @param string $storeId
      * @param string $productId
      * @param array $data
-     * @return array|false
      */
     public function updateProduct(string $storeId, string $productId, array $data);
 
     /**
      * @param string $storeId
      * @param string $productId
-     * @return array|false
      */
     public function removeProduct(string $storeId, string $productId);
 
     /**
      * @param string $storeId
      * @param array $data
-     * @return array|false
      */
     public function addOrder(string $storeId, array $data);
 
-    /**
-     * @return array|false
-     */
     public function getOrders();
 
     /**
      * @param string $storeId
-     * @return array|false
      */
     public function getOrdersByStore(string $storeId);
 
     /**
      * @param string $storeId
      * @param string $orderId
-     * @return array|false
      */
     public function getOrder(string $storeId, string $orderId);
 
     /**
      * @param string $storeId
      * @param string $orderId
      * @param array $data
-     * @return array|false
      */
     public function updateOrder(string $storeId, string $orderId, array $data);
 
     /**
      * @param string $storeId
      * @param string $orderId
-     * @return array|false
      */
     public function removeOrder(string $storeId, string $orderId);
 
     /**
      * @param string $storeId
      * @param array $data
-     *
-     * @return array|false
      */
     public function addCart(string $storeId, array $data);
 
     /**
      * @param string $storeId
-     * @return array|false
      */
     public function getCarts(string $storeId);
 
     /**
      * @param string $storeId
      * @param string $cartId
-     * @return array|false
      */
     public function getCart(string $storeId, string $cartId);
 
     /**
      * @param string $storeId
      * @param string $cartId
      * @param array $data
-     * @return array|false
      */
     public function updateCart(string $storeId, string $cartId, array $data);
 
     /**
      * @param string $storeId
      * @param string $cartId
-     * @return array|false
      */
     public function removeCart(string $storeId, string $cartId);
 }
diff --git a/src/Api/ListsInterface.php b/src/Api/ListsInterface.php
@@ -9,29 +9,25 @@ interface ListsInterface
     /**
      * @param string $listId
      * @param array $data
-     * @return array|false
      */
     public function addMember(string $listId, array $data);
 
     /**
      * @param string $listId
      * @param string $hash
-     * @return array|false
      */
     public function getMember(string $listId, string $hash);
 
     /**
      * @param string $listId
      * @param string $hash
      * @param array $data
-     * @return array|false
      */
     public function updateMember(string $listId, string $hash, array $data);
 
     /**
      * @param string $listId
      * @param string $hash
-     * @return array|false
      */
     public function removeMember(string $listId, string $hash);
 }
diff --git a/src/Command/SyncAllCommand.php b/src/Command/SyncAllCommand.php
@@ -28,7 +28,7 @@ protected function configure(): void
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $withPurge = $input->getOption('purge');
         $createOnly = $input->getOption('create-only');
@@ -68,5 +68,7 @@ protected function execute(InputInterface $input, OutputInterface $output): void
                 '--isSyncing' => false,
             ]), $output);
         }
+
+        return 0;
     }
 }
diff --git a/src/Command/SyncCartsCommand.php b/src/Command/SyncCartsCommand.php
@@ -45,13 +45,15 @@ protected function configure(): void
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->io = new SymfonyStyle($input, $output);
 
         $this->io->title('Synchronizing the carts to Mailchimp');
 
         $this->registerCarts($input);
+
+        return 0;
     }
 
     /**

diff --git a/src/Command/SyncCustomersCommand.php b/src/Command/SyncCustomersCommand.php
@@ -52,13 +52,15 @@ protected function configure(): void
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->io = new SymfonyStyle($input, $output);
 
         $this->io->title('Synchronizing the customers to Mailchimp');
 
         $this->registerCustomers($input);
+
+        return 0;
     }
 
     /**

diff --git a/src/Command/SyncOrdersCommand.php b/src/Command/SyncOrdersCommand.php
@@ -46,13 +46,15 @@ protected function configure(): void
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->io = new SymfonyStyle($input, $output);
 
         $this->io->title('Synchronizing the orders to Mailchimp');
 
         $this->registerOrders($input);
+
+        return 0;
     }
 
     /**

diff --git a/src/Command/SyncProductsCommand.php b/src/Command/SyncProductsCommand.php
@@ -46,13 +46,15 @@ protected function configure(): void
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->io = new SymfonyStyle($input, $output);
 
         $this->io->title('Synchronizing the products to Mailchimp');
 
         $this->registerProducts($input);
+
+        return 0;
     }
 
     /**

diff --git a/src/Command/SyncStoresCommand.php b/src/Command/SyncStoresCommand.php
@@ -46,13 +46,15 @@ protected function configure(): void
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output): void
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $this->io = new SymfonyStyle($input, $output);
 
         $this->io->title('Synchronizing the stores to Mailchimp');
 
         $this->registerStores($input);
+
+        return 0;
     }
 
     /**

diff --git a/src/Handler/CartRegisterHandlerInterface.php b/src/Handler/CartRegisterHandlerInterface.php
@@ -11,13 +11,11 @@ interface CartRegisterHandlerInterface
     /**
      * @param OrderInterface $order
      * @param bool $createOnly
-     * @return array|false
      */
     public function register(OrderInterface $order, bool $createOnly = false);
 
     /**
      * @param OrderInterface $order
-     * @return array|false
      */
     public function unregister(OrderInterface $order);
 }
diff --git a/src/Handler/CustomerNewsletterSubscriptionHandlerInterface.php b/src/Handler/CustomerNewsletterSubscriptionHandlerInterface.php
@@ -11,14 +11,12 @@ interface CustomerNewsletterSubscriptionHandlerInterface
     /**
      * @param CustomerInterface $customer
      * @param string $listId
-     * @return array|false
      */
     public function subscribe(CustomerInterface $customer, string $listId);
 
     /**
      * @param CustomerInterface $customer
      * @param string $listId
-     * @return array|false
      */
     public function unsubscribe(CustomerInterface $customer, string $listId);
 }
diff --git a/src/Handler/CustomerRegisterHandlerInterface.php b/src/Handler/CustomerRegisterHandlerInterface.php
@@ -14,7 +14,6 @@ interface CustomerRegisterHandlerInterface
      * @param ChannelInterface $channel
      * @param bool $optInStatus
      * @param bool $createOnly
-     * @return array|false
      */
     public function register(
         CustomerInterface $customer,
@@ -26,7 +25,6 @@ public function register(
     /**
      * @param CustomerInterface $customer
      * @param ChannelInterface $channel
-     * @return array|false
      */
     public function unregister(CustomerInterface $customer, ChannelInterface $channel);
 }
diff --git a/src/Handler/OrderRegisterHandlerInterface.php b/src/Handler/OrderRegisterHandlerInterface.php
@@ -11,13 +11,11 @@ interface OrderRegisterHandlerInterface
     /**
      * @param OrderInterface $order
      * @param bool $createOnly
-     * @return array|false
      */
     public function register(OrderInterface $order, bool $createOnly = false);
 
     /**
      * @param OrderInterface $order
-     * @return array|false
      */
     public function unregister(OrderInterface $order);
 }
diff --git a/src/Handler/ProductRegisterHandler.php b/src/Handler/ProductRegisterHandler.php
@@ -139,7 +139,12 @@ private function getVariantPrice(ProductVariant $variant, ChannelInterface $chan
         /** @var ChannelPricingInterface $channelPricing */
         $channelPricing = $variant->getChannelPricingForChannel($channel);
 
-        return $channelPricing !== null ? $channelPricing->getPrice() : null;
+        $variantPrice = null;
+        if ($channelPricing instanceof ChannelPricingInterface) {
+            $variantPrice = $channelPricing->getPrice();
+        }
+
+        return $variantPrice;
     }
 
     /**

diff --git a/src/Handler/ProductRegisterHandlerInterface.php b/src/Handler/ProductRegisterHandlerInterface.php
@@ -13,14 +13,12 @@ interface ProductRegisterHandlerInterface
      * @param ProductInterface $product
      * @param ChannelInterface $channel
      * @param bool $createOnly
-     * @return array|false
      */
     public function register(ProductInterface $product, ChannelInterface $channel, bool $createOnly = false);
 
     /**
      * @param ProductInterface $product
      * @param ChannelInterface $channel
-     * @return array|false
      */
     public function unregister(ProductInterface $product, ChannelInterface $channel);
 }