-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement of phantoms in the library #463
Comments
I think Regarding images, I am very reluctant to include any at all. If an image is to be added, it better have a real extra value that none of the existing phantoms can provide. Regarding 3d volumes, even stronger objection. I don't want If we really want to have examples using digital 2d and 3d data (not programmatically created), we should create a separate repository |
Also did the following fixed to phantoms * Optimized 2d ellipse phantoms in same way as 3d * Fixed bug with submarined in non centered geometries
Also did the following fixed to phantoms * Optimized 2d ellipse phantoms in same way as 3d * Fixed bug with submarined in non centered geometries
Currently all phantoms are accessible under
odl.util
. As the number of phantom grows with relatively high speed right now I am considering if we should formalize this a bit more.One option would be to put them under
odl.phantom
, that way we could also separate them a bit (like having CT phantoms SPECT phantoms in different files). It would also be easier to find what phantoms are available.Another option is to start naming them something that starts with
phantom_
, this does however feel a bit arbitrary:odl.util.phantom_shepp_logan
etc.A final issue is that it seems we may want to add images to the library as phantoms. We need to discuss in what cases we should do this, and some limitations on the images
The text was updated successfully, but these errors were encountered: