Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductSpace.__getitem__ should return a Productspace #54

Closed
adler-j opened this issue Nov 19, 2015 · 0 comments
Closed

ProductSpace.__getitem__ should return a Productspace #54

adler-j opened this issue Nov 19, 2015 · 0 comments
Assignees

Comments

@adler-j
Copy link
Member

adler-j commented Nov 19, 2015

As noted in implementing #53 ProductSpace.__getitem__ currently returns a list if indices is a slice:

return self.spaces[indices]

In the case where indices is a slice, ProductSpace.__getitem__ should do:

return ProductSpace(self.spaces[indices])

to be sure, this should fail if the space has a custom norm (since this does not transfer trivially).

if indices is a int, we should simply

return self.spaces[indices]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants