Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 761 nlm #1052

Merged
merged 6 commits into from Aug 5, 2017
Merged

Issue 761 nlm #1052

merged 6 commits into from Aug 5, 2017

Conversation

adler-j
Copy link
Member

@adler-j adler-j commented Jun 29, 2017

New PR from my account. Lets get this out of the way.

@adler-j adler-j mentioned this pull request Jun 29, 2017
4 tasks
@adler-j
Copy link
Member Author

adler-j commented Jun 29, 2017

Did some cleanup, should be reviewable. Keep in mind this in contrib stuff

Copy link
Member

@kohr-h kohr-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few high-level comments.

# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with ODL. If not, see <http://www.gnu.org/licenses/>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove header

# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with ODL. If not, see <http://www.gnu.org/licenses/>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

References
----------
.. _Buades2005: http://ieeexplore.ieee.org/document/1467423/
.. _FlexISP: http://dl.acm.org/citation.cfm?doid=2661229.2661260
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference style

e^{-\\frac{(G_a * |u(x + \cdot) - u(y + \cdot)|^2)(0)}{h^2}}
dy

See FlexISP_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the prox?

def proximal(self):
func = self

class NLMProximal(Operator):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expression for this guy?

# odl.contrib.solvers

- Contributed additions to the [odl.solvers](../../solvers) package.
- Contains application specific functionals and solvers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] package, intended for application-specific functionals and solvers.

@adler-j adler-j force-pushed the issue-761__NLM branch 3 times, most recently from 7245e16 to 0434a26 Compare August 5, 2017 22:29
@adler-j adler-j merged commit a6a2b66 into odlgroup:master Aug 5, 2017
@adler-j adler-j deleted the issue-761__NLM branch August 5, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants