Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 32 add test for newton solver #34

Merged
merged 5 commits into from
Nov 17, 2015

Conversation

adler-j
Copy link
Member

@adler-j adler-j commented Nov 17, 2015

Making a pull request for this so we can discuss it! Almost done as well.

aringh and others added 2 commits November 17, 2015 14:23
Adds test to Newton solver, according to instructions in
odlgroup/odl-solvers#9. Related to the issue odlgroup/odl-solvers#7.
See #32
@adler-j
Copy link
Member Author

adler-j commented Nov 17, 2015

Travis complains about pep8 compliance, lets fix that.

@adler-j
Copy link
Member Author

adler-j commented Nov 17, 2015

Also the code doesn't run at all since ImportError: No module named odl_solvers, we need to get #20 solved quite quickly here.

@kohr-h
Copy link
Member

kohr-h commented Nov 17, 2015

Yes. Stop working, I'll move the code.

@adler-j
Copy link
Member Author

adler-j commented Nov 17, 2015

Okay, ill stop working and go home then!

@kohr-h
Copy link
Member

kohr-h commented Nov 17, 2015

Okay, I guess we're back in business on this branch. Let's see what Travis says.

@kohr-h
Copy link
Member

kohr-h commented Nov 17, 2015

To me this looks good now. We'll come back with more structure later.

kohr-h added a commit that referenced this pull request Nov 17, 2015
…lver

Issue 32:  add test for newton solver
@kohr-h kohr-h merged commit ace54df into master Nov 17, 2015
@kohr-h kohr-h deleted the issue-32__add_test_for_newton_solver branch November 17, 2015 19:20
@aringh aringh mentioned this pull request Nov 18, 2015
aringh pushed a commit to aringh/odl that referenced this pull request Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants