Issue 443 uniform partition #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| >>> part.cell_boundary_vecs | ||
| (array([ 0. , 0.5, 1. ]), array([ 1.5 , 1.75, 2. ])) | ||
| """ | ||
| # np.size(None) = 1 |
There was a problem hiding this comment.
nitpicking: # np.size(None) == 1
|
Functionality i great, but I'm not sure that this should be separate from Regarding |
kohr-h
force-pushed
the
issue-443__uniform_partition
branch
from
17118d9
to
1f6a7ee
Compare
|
Done with all the comments and rebased. Waiting for Travis to be happy. Now the functionality is merged into |
| cell_sides=None, nodes_on_bdry=False): | ||
| """Return a partition with equally sized cells. | ||
|
|
||
| This function offers more flexibility over `uniform_partition` in |
There was a problem hiding this comment.
Old comment. Should be updated with call syntax.
|
Great changes, some minor comments then we should be fine. |
|
Missclick on close... |
Instead of always expecting begin, end and num_nodes, now cell_sides can be given in addition, and one of the first three parameters can be left out instead. This can be done per axis.
kohr-h
force-pushed
the
issue-443__uniform_partition
branch
from
1f6a7ee
to
024552f
Compare
|
Fixed the old stuff, will merge after tests have run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
uniform_partition_optionsas mentioned in #443. The name is sub-optimal but quite clearly, the function should be separate fromuniform_partition.Closes #443