ENH: add default nlevels to wavelet trafo, closes #866 #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adler-j
commented
Feb 6, 2017
odl/trafos/backends/pywt_bindings.py
Outdated
| >>> pywt_max_nlevels([10, 1024], 'haar') | ||
| 3 | ||
| """ | ||
|
|
kohr-h
approved these changes
Feb 12, 2017
odl/trafos/backends/pywt_bindings.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| shape : sequence |
odl/trafos/backends/pywt_bindings.py
Outdated
| @@ -180,6 +180,48 @@ def pywt_coeff_shapes(shape, wavelet, nlevels, mode): | |||
| return shape_list | |||
|
|
|||
|
|
|||
| def pywt_max_nlevels(shape, wavelet): | |||
| """Return the maximum nlevels option. | |||
There was a problem hiding this comment.
Is "Return the maximum number of wavelet levels" better?
|
I must have been drunk while writing this. This stuff: max_nlevels = np.inf
for i, n in enumerate(shape):
max_nlevels = min(max_nlevels, pywt.dwt_max_level(n, wavelet.dec_len))has both an unused variable max_nlevels = min(pywt.dwt_max_level(n, wavelet.dec_len) for n in shape)Anyway, fixed that and removed some redundancy in other places. Merge after CI. |
adler-j
force-pushed
the
issue-866__default_wavelet_nlevels
branch
from
d8ea024
to
8249a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.