Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Catalan locale code in translations filename #116

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

aprat84
Copy link

@aprat84 aprat84 commented Jun 20, 2022

Catalan base language code is ca. The ca_ES code is just a country-specific dialect (Catalan from Spain). Just like en, es and pt are base language codes and en_AU (English from Australia), es_419 (Spanish from LATAM) and pt_BR (Portuguese from Brazil) are dialects.

Catalan in wikipedia
Common IETF primary language subtags

@Nek-
Copy link
Collaborator

Nek- commented Jun 26, 2022

Hello,

Thank you very much for your contribution! Links to documentation are a real appreciation, you did great.

This is an interesting mistake here. I have no insight about that... It's ok for me to make this change, but if somebody with a little more knowledge about translation may be valid this, that would be great.

@aprat84
Copy link
Author

aprat84 commented Jun 27, 2022

Looking at examples from symfony github or some popular libraries, ca is the way to go:
Symfony Validator
Symfony Security
Carbon
moment.js

I'll put it another way: if I want to use Catalan in symfony, I'll configure it with ca locale. If I do this, symfony translations (validators, security) work well, but this library's don't.

@Nek- Nek- merged commit 6de616a into odolbeau:master Jun 27, 2022
@Nek-
Copy link
Collaborator

Nek- commented Jun 27, 2022

Thank you very much for your contribution !

@Nek- Nek- mentioned this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants