[FW][FIX] theme_avantgarde : colour variable fix #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the previously hardcoded color customisations in theme Avantgarde's snippets, by using proper color variables, which allow the snippet customisations to change dynamically. While theoretically unstable (changing views), this was judged safe enough for 15.0 (it would require someone to xpath a theme.ir.ui.view in this specific theme, targeting an inline style to break; and it does not change the current websites at all (just new dropped snippets)). X-original-commit: 65baa9b
|
This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Jul 1, 2022
This commit fixes the previously hardcoded color customisations in theme Avantgarde's snippets, by using proper color variables, which allow the snippet customisations to change dynamically. While theoretically unstable (changing views), this was judged safe enough for 15.0 (it would require someone to xpath a theme.ir.ui.view in this specific theme, targeting an inline style to break; and it does not change the current websites at all (just new dropped snippets)). closes #575 X-original-commit: 65baa9b Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
fw-bot
deleted the
saas-15.1-master-themes-colour-variable-fix-cvs-En7A-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] theme_avantgarde : colour variable fix
This commit fixes the previous hardcoded assignation to colour
customisations in theme Avantgarde's snippets, by using proper
colour variables, which allow the snippet customisations change
dynamically.
Forward-Port-Of: #509