Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] config: werkzeug 1.0.x docs are no longer online #5219

Closed
wants to merge 1 commit into from

Conversation

aj-fuentes
Copy link
Contributor

❯ curl -sw '%{http_code}\n' -o /dev/null https://werkzeug.palletsprojects.com/en/1.0.x/
404

❯ curl -sw '%{http_code}\n' -o /dev/null https://werkzeug.palletsprojects.com/en/2.0.x/
200

```
❯ curl -sw '%{http_code}\n' -o /dev/null https://werkzeug.palletsprojects.com/en/1.0.x/
404

❯ curl -sw '%{http_code}\n' -o /dev/null https://werkzeug.palletsprojects.com/en/2.0.x/
200
```
@robodoo
Copy link
Collaborator

robodoo commented Jul 27, 2023

@aj-fuentes aj-fuentes requested a review from KangOl July 27, 2023 08:29
@C3POdoo C3POdoo requested a review from a team July 27, 2023 08:30
@aj-fuentes
Copy link
Contributor Author

@fw-bot ignore

@fw-bot
Copy link
Collaborator

fw-bot commented Jul 27, 2023

Forward-port disabled.

@KangOl
Copy link
Contributor

KangOl commented Jul 27, 2023

@aj-fuentes
Copy link
Contributor Author

@KangOl

What about linking to the archived url?

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://web.archive.org/web/20230308050341/https://werkzeug.palletsprojects.com/en/1.0.x/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: NOT FOUND for url: https://web.archive.org/web/20230308050341/https://werkzeug.palletsprojects.com/en/1.0.x/objects.inv

And there is nothing archived for 1.0.x/objects.inv.

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this has already been fixed in 14.0, the lowest version still being built on odoo.com and runbot.

@AntoineVDV AntoineVDV closed this Jul 27, 2023
@aj-fuentes
Copy link
Contributor Author

@AntoineVDV this is to support PRs for older versions. Although unsupported it's important for upgrades.

@AntoineVDV AntoineVDV reopened this Jul 27, 2023
@AntoineVDV
Copy link
Collaborator

Ok then

@robodoo r+
@fw-bot ignore

@fw-bot
Copy link
Collaborator

fw-bot commented Jul 27, 2023

Forward-port disabled.

@robodoo
Copy link
Collaborator

robodoo commented Jul 27, 2023

@aj-fuentes @AntoineVDV linked pull request(s) odoo/enterprise#44640 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Jul 27, 2023
```
❯ curl -sw '%{http_code}\n' -o /dev/null https://werkzeug.palletsprojects.com/en/1.0.x/
404

❯ curl -sw '%{http_code}\n' -o /dev/null https://werkzeug.palletsprojects.com/en/2.0.x/
200
```

closes #5219

Related: odoo/enterprise#44640
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@robodoo robodoo temporarily deployed to merge July 27, 2023 11:02 Inactive
@robodoo robodoo closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants