Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] sales: updated pro-forma invoice doc for 16 #5553

Closed
wants to merge 1 commit into from
Closed

[IMP] sales: updated pro-forma invoice doc for 16 #5553

wants to merge 1 commit into from

Conversation

ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented Aug 18, 2023 •
edited by samueljlieber
Loading

@ksc-odoo ksc-odoo self-assigned this Aug 18, 2023
@robodoo
Copy link
Collaborator

robodoo commented Aug 18, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team August 18, 2023 22:46
@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-pro-forma-invoice-ksc branch from 7d93d5f to 0085ac6 Compare August 18, 2023 22:49
@ksc-odoo ksc-odoo requested a review from a team November 6, 2023 19:48
jero-odoo
jero-odoo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo great job! Just one real note, so I am pushing this through with approval 👍

content/applications/sales/sales/invoicing/proforma.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma.rst Show resolved Hide resolved
@ksc-odoo ksc-odoo removed the request for review from a team November 16, 2023 21:34
@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-pro-forma-invoice-ksc branch from 0085ac6 to 17bdce0 Compare November 17, 2023 21:22
@ksc-odoo
Copy link
Contributor Author

Thanks for the feedback, @jero-odoo 👍 I made all your suggested edits, and since you've already approved this PR (w/ those changes), I'll pass it on to the Materials team for a 2nd peer review ... so, this one's ready for ya: @hojo-odoo @Felicious @brse-odoo

hojo-odoo
hojo-odoo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo,

Good job on this. Just a few comments for you to take a look at before tagging for final review.

Thanks,
hojo

content/applications/sales/sales/invoicing/proforma.rst Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma.rst Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-pro-forma-invoice-ksc branch 2 times, most recently from 7a02b7d to c467fee Compare November 27, 2023 18:54
@ksc-odoo
Copy link
Contributor Author

Thanks for the helpful feedback @hojo-odoo -- I made those suggested edits, and believe this one is now ready for final review from @odoo/us-doc-review 👍

samueljlieber
samueljlieber requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, nice job with this PR! I have a few technical corrections and suggestions. Please see below and then tag me for another look once ready! Thank you 🙂

content/applications/sales/sales/invoicing/proforma.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma/pro-forma-email-message-popup.png Outdated Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma/pro-forma-setting.png Outdated Show resolved Hide resolved
content/applications/sales/sales/invoicing/proforma/send-pro-forma-invoice-button.png Outdated Show resolved Hide resolved
@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-pro-forma-invoice-ksc branch from c467fee to 2d035fb Compare November 27, 2023 23:47
@ksc-odoo
Copy link
Contributor Author

Thanks for your always-helpful feedback @samueljlieber -- I made all your suggested adjustments, so this one is ready for another quick review from you whenever you get a chance. Once I get your approval, I'll pass it along to the Final Review stage. Thanks again 👍

samueljlieber
samueljlieber approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo, thanks for implementing my previous suggestions! I caught two more small fixes, which I will push up now to move this PR forward for merge. Thank you!

content/applications/sales/sales/invoicing/proforma.rst Outdated
In order to utilize pro-forma invoices, the *Pro-Forma Invoice* feature **must** be activated.

To enable this feature, navigate to :menuselection:`Sales app --> Configuration --> Settings`, and
in the :guilabel:`Quotations & Orders` section, click the checkbox next to :guilabel:`Pro-Forma
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ampersand does not appear to break the rst, but let's escape it just in case

Suggested change
in the :guilabel:`Quotations & Orders` section, click the checkbox next to :guilabel:`Pro-Forma
in the :guilabel:`Quotations \& Orders` section, click the checkbox next to :guilabel:`Pro-Forma

content/applications/sales/sales/invoicing/proforma/pro-forma-email-message-popup.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image needs to be compressed :)

@samueljlieber samueljlieber force-pushed the 16.0-sales-update-pro-forma-invoice-ksc branch from 2d035fb to 0f43049 Compare December 5, 2023 15:31
@samueljlieber samueljlieber requested a review from a team December 5, 2023 15:33
samueljlieber
samueljlieber approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StraubCreative this PR is good to go 👍

FWP up to master

@StraubCreative
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 7, 2023
@ksc-odoo @samueljlieber
[IMP] sales: updated pro-forma invoice doc for 16
bbbb00e 
closes #5553

Signed-off-by: Zachary Straub (zst) <zst@odoo.com>
@robodoo robodoo closed this Dec 7, 2023
This was referenced Dec 7, 2023
Closed
Closed
Closed
This was referenced Dec 7, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

@jero-odoo jero-odoo jero-odoo approved these changes

@hojo-odoo hojo-odoo hojo-odoo approved these changes

Assignees

@ksc-odoo ksc-odoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ksc-odoo @robodoo @StraubCreative @samueljlieber @jero-odoo @hojo-odoo