Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Pricer tags section added to PoS/pricing #6539

Closed
wants to merge 1 commit into from

Conversation

Ysoroko
Copy link
Contributor

@Ysoroko Ysoroko commented Nov 21, 2023

This PR adds the documentation needed to use Point Of Sale with Pricer electronic price tags.

Related PRs:
Pos Pricer module added:
https://github.com/odoo/enterprise/pull/50368

task-3603496

@robodoo
Copy link
Collaborator

robodoo commented Nov 21, 2023

@C3POdoo C3POdoo requested a review from a team November 21, 2023 15:48
@Ysoroko Ysoroko force-pushed the 17.0-pricer-documentation-yaso branch 3 times, most recently from 4f6deb6 to 1e48a37 Compare November 21, 2023 16:41
@LoredanaLrpz LoredanaLrpz marked this pull request as draft December 18, 2023 12:51
@LoredanaLrpz LoredanaLrpz force-pushed the 17.0-pricer-documentation-yaso branch 5 times, most recently from 3c1d5e4 to fdedc0b Compare March 13, 2024 11:05
@LoredanaLrpz LoredanaLrpz marked this pull request as ready for review March 13, 2024 11:05
Copy link
Contributor

@zulu-odoo zulu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Miss Loredana,
Great job! I left some comments, but other than a little punctuation typo, there's nothing that objectively needs to be changed, just some suggestions. You're 100% free to disregard them if you disagree ;)
If you want to discuss in person, let me know and we do it on Thursday!
Putting this on request changes so you can check the comments.

@LoredanaLrpz LoredanaLrpz force-pushed the 17.0-pricer-documentation-yaso branch 2 times, most recently from 384a970 to c5f1728 Compare March 21, 2024 11:57
Copy link
Contributor

@zulu-odoo zulu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! :)

@LoredanaLrpz LoredanaLrpz requested a review from a team March 21, 2024 12:30
@LoredanaLrpz LoredanaLrpz force-pushed the 17.0-pricer-documentation-yaso branch from c5f1728 to 1aa0a3a Compare March 21, 2024 13:27
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions. @robodoo delegate+

task-3603496

This PR adds the documentation needed to use Point Of Sale
with Pricer electronic price tags.

Related PRs:
odoo/enterprise#50368

task-3603496
@LoredanaLrpz LoredanaLrpz force-pushed the 17.0-pricer-documentation-yaso branch from 1aa0a3a to 89b91e8 Compare March 28, 2024 10:52
@LoredanaLrpz
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Mar 28, 2024

I'm sorry, @LoredanaLrpz. I'm afraid I can't do that.

@xpl-odoo
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants