[ADD] inventory: package use and type #7734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
9464da3
to
5794b2f
Compare
hojo-odoo
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Hey @Felicious,
Great job on this doc. It should be ready for the second round of review after you take a look at my comments.
Thanks,
hojo
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
2ed6f35
to
5309e77
Compare
|
Hi @odoo/us-doc-review, this doc has passed the first round of peer review, and I've proofread it myself with ChatGPT. This doc is ready for you to take a look! |
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
5309e77
to
63b2046
Compare
Felicious
force-pushed
the
16.0-inventory-uom-feku
branch
from
a6806bd
to
55d65e8
Compare
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
63b2046
to
9d79cda
Compare
ksc-odoo
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Hey @Felicious great work on this doc! I have a handful of comments and feedback that require your attention. But, once you make the necessary adjustments, tag me again for another quick look. Thanks! 👍
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
2 times, most recently
from
4720f3a
to
be4a27d
Compare
Felicious
force-pushed
the
16.0-inventory-uom-feku
branch
from
55d65e8
to
bf57fff
Compare
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
be4a27d
to
41186b9
Compare
|
Thanks for your initial review, @ksc-odoo ! This PR is ready for you to take a second look. I had left a comment asking your opinion, but in my next PR, I actually decided to axe this batch transfers section because the expert let me know that this section isn't really relevant/accurate: But, I'm still interested in your thoughts on broader documentation best practices, like:
|
Felicious
force-pushed
the
16.0-inventory-uom-feku
branch
from
79b272a
to
7833535
Compare
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
41186b9
to
1909b2d
Compare
Felicious
force-pushed
the
16.0-inventory-uom-feku
branch
from
7833535
to
87ceae6
Compare
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
1909b2d
to
70890ef
Compare
Felicious
force-pushed
the
16.0-inventory-uom-feku
branch
from
87ceae6
to
62173cd
Compare
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
70890ef
to
fe9e5a2
Compare
Felicious
commented
Feb 23, 2024
|
|
||
| .. image:: package/pack-internal-link.png | ||
| :align: center | ||
| :alt: Show internal link |
There was a problem hiding this comment.
Need a period at the end of the alt tag here, but in the next update PR: #7797
This image gets removed, so I wouldn't worry about this (;
ksc-odoo
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Looks good to me @Felicious Just a couple more, super small things that require your attention, but I'm going to go ahead and approve this. Once you make those adjustments, you can move this to the next stage. 👍
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
...ons/inventory_and_mrp/inventory/warehouses_storage/advanced_operations_warehouse/package.rst
Outdated
Show resolved
Hide resolved
|
CI checks pass as of e935363. Base target needed to be changed from seed feature branch |
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
e935363
to
ed3ef7c
Compare
StraubCreative
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Looks good thanks @Felicious
Quick line fix on 122
@robodoo delegate=Felicious
...ent/applications/inventory_and_mrp/inventory/product_management/product_tracking/package.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Zachary Straub <zst@odoo.com>
Felicious
force-pushed
the
16.0-inventory-package-feku
branch
from
654904b
to
75387bb
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
closes #7734 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Zachary Straub <zst@odoo.com>
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reviewers
Merge order
Merge after #7659
FWPort
Yes, all the way to the newest version