Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Recruitment: updating images and instructions for 17 #7869

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

larm-odoo
Copy link
Contributor

Need to update the doc to reflect the changes made in 17

@larm-odoo larm-odoo marked this pull request as draft February 23, 2024 22:27
@robodoo
Copy link
Collaborator

robodoo commented Feb 23, 2024

@larm-odoo larm-odoo force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from 8456c8e to 2766f3a Compare February 28, 2024 18:37
@larm-odoo larm-odoo marked this pull request as ready for review February 28, 2024 18:38
@C3POdoo C3POdoo requested a review from a team February 28, 2024 18:38
@larm-odoo larm-odoo force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from 2766f3a to 5f31474 Compare February 28, 2024 19:35
@larm-odoo larm-odoo requested review from hojo-odoo and removed request for jero-odoo February 28, 2024 19:35
@larm-odoo
Copy link
Contributor Author

Hey @hojo-odoo, I don't think I've had a review form you in a long time, so I am tagging you for my peer review. Thank you!

@larm-odoo larm-odoo self-assigned this Mar 20, 2024
@StraubCreative StraubCreative requested review from StraubCreative and removed request for hojo-odoo March 29, 2024 00:02
@StraubCreative StraubCreative force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from 5f31474 to 89edc58 Compare March 29, 2024 00:04
@StraubCreative
Copy link
Contributor

StraubCreative commented Mar 29, 2024

Fresh rebase on 89edc58 to rebuild the runbot instance 👍

EDIT:
Fixed failing CI error on dccd8c2, line 121, which referenced old IAP doc location before it was moved to the essentials directory.

@StraubCreative StraubCreative force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from 89edc58 to dccd8c2 Compare March 29, 2024 00:13
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo

Here's my first round of peer review, to get you started!

As always, your documentation is so detailed and really impressive 🙂 Please see my comments for you below for you to consider, as they mostly have to do with the content itself and perhaps expanding UI coverage in some spots. You'll notice a few writing-specific comments as well, where I caught them (however I leave the majority of those suggestions up to Final Review 😉).

Please let me know if you have any questions on this batch.
I'll add more comments soon!

content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Show resolved Hide resolved
@larm-odoo larm-odoo force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from dccd8c2 to d943921 Compare March 29, 2024 20:31
@StraubCreative StraubCreative force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from d943921 to b7d3557 Compare May 13, 2024 19:42
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo
Thorough as always!
I just had some high-level stuff for you to consider here. Feel free to apply what you agree with and then you can tag SALI or me again for a tech review (whoever can get to it first).
Thanks for the great work here!

content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
content/applications/hr/recruitment.rst Outdated Show resolved Hide resolved
Co-authored-by: StraubCreative <zst@odoo.com>
@larm-odoo larm-odoo force-pushed the 17.0-recruitment-updating-config-and-flow-larm branch from b7d3557 to e346177 Compare May 14, 2024 21:53
@larm-odoo larm-odoo requested a review from a team May 14, 2024 21:53
@larm-odoo
Copy link
Contributor Author

This is ready for a tech review when you have a chance, @samueljlieber! If you are busy, @StraubCreative can do it. Whoever gets to it first, really. =)

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo! Thanks for your thorough improvements to the Recruitment doc! I am approving with some comments, please let me know if you have any questions! Thank you for your hard work 😊
...
@robodoo delegate=larm-odoo

Comment on lines +38 to +39
To view and edit the settings, navigate to :menuselection:`Recruitment app --> Settings`. After any
changes are made, click the :guilabel:`Save` button in the top-left corner to save all the changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing menu step :)

Suggested change
To view and edit the settings, navigate to :menuselection:`Recruitment app --> Settings`. After any
changes are made, click the :guilabel:`Save` button in the top-left corner to save all the changes.
To view and edit the settings, navigate to :menuselection:`Recruitment app --> Configuration -->
Settings`. After any changes are made, click the :guilabel:`Save` button in the top-left corner to
save all the changes.

Posting` option.

.. note::
The :guilabel:`Online Posting` only works if the *Website* application is also installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only works, or is only available if..?

Suggested change
The :guilabel:`Online Posting` only works if the *Website* application is also installed.
The :guilabel:`Online Posting` is only available if the *Website* application is also installed.

Comment on lines +54 to +55
This section of the settings page specifies what the database can and cannot do during the
recruitment process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid "this"

Suggested change
This section of the settings page specifies what the database can and cannot do during the
recruitment process.
The :guilabel:`Recruitment process` section of the settings page specifies what the database can and
cannot do during the recruitment process.

Comment on lines +70 to +71
*Recruitment* app. If no surveys have been created, the surveys list displays a `No Survey Found`
message, and presents options to create a survey from several pre-configured survey templates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text displayed on the active UI should have a :guilabel:

Suggested change
*Recruitment* app. If no surveys have been created, the surveys list displays a `No Survey Found`
message, and presents options to create a survey from several pre-configured survey templates.
*Recruitment* app. If no surveys have been created, the surveys list displays a :guilabel:`No Survey
Found` message, and presents options to create a survey from several pre-configured survey
templates.


.. seealso::
For more detailed information about surveys, refer to the :doc:`survey essentials
</applications/marketing/surveys/create>` documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use relative paths :)

Suggested change
</applications/marketing/surveys/create>` documentation.
<../marketing/surveys/create>` documentation.

Comment on lines +592 to +593
ways, using either the :ref:`Quick add <recruitment/quick-add-applicant>` icon or the :ref:`New
<recruitment/create-new-applicant>` button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no text on the UI stating "Quick add", so you can leave it lowercase and state it is a button, whereas the icon is the + sign

Suggested change
ways, using either the :ref:`Quick add <recruitment/quick-add-applicant>` icon or the :ref:`New
<recruitment/create-new-applicant>` button.
ways, using either the :ref:`quick add <recruitment/quick-add-applicant>` button or the :ref:`New
<recruitment/create-new-applicant>` button.

:ref:`Create <recruitment/create-new-applicant>` button.
job online) an applicant card can be easily added from the job position Kanban view in one of two
ways, using either the :ref:`Quick add <recruitment/quick-add-applicant>` icon or the :ref:`New
<recruitment/create-new-applicant>` button.

.. _recruitment/quick-add-applicant:

Quick add
*********

Quickly add a new applicant using the :guilabel:`Quick add` icon. If not already in the job position
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Quickly add a new applicant using the :guilabel:`Quick add` icon. If not already in the job position
Quickly add a new applicant using the *quick add* button. If not already in the job position Kanban

Comment on lines +601 to +604
Kanban view, navigate to the main recruitment dashboard by going to :menuselection:`Recruitment app
--> Applications --> By Job Positions`. Click the :guilabel:`(#) New Applications` button on the job
position card that the applicant should be added to. Then, click on the small :guilabel:`+ (plus
sign) Quick add` icon in the top-right of the :guilabel:`New` stage to quickly add a new applicant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kanban view, navigate to the main recruitment dashboard by going to :menuselection:`Recruitment app
--> Applications --> By Job Positions`. Click the :guilabel:`(#) New Applications` button on the job
position card that the applicant should be added to. Then, click on the small :guilabel:`+ (plus
sign) Quick add` icon in the top-right of the :guilabel:`New` stage to quickly add a new applicant.
view, navigate to the main recruitment dashboard by going to :menuselection:`Recruitment app -->
Applications --> By Job Positions`. Click the :guilabel:`(#) New Applications` button on the job
position card that the applicant should be added to. Then, click on the small :icon:`fa-plus`
:guilabel:`(plus)` icon in the top-right of the :guilabel:`New` stage to quickly add a new
applicant.

Comment on lines +637 to +641
Add a new applicant including all the relevant information using the :guilabel:`New` button. If not
already in the Kanban view for the job position to add an applicant to, navigate to the main
recruitment dashboard by going to :menuselection:`Recruitment app --> Applications --> By Job
Positions`. Then, click the :guilabel:`New` button in the top-left of the Kanban view and a blank
applicant form loads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add a new applicant including all the relevant information using the :guilabel:`New` button. If not
already in the Kanban view for the job position to add an applicant to, navigate to the main
recruitment dashboard by going to :menuselection:`Recruitment app --> Applications --> By Job
Positions`. Then, click the :guilabel:`New` button in the top-left of the Kanban view and a blank
applicant form loads.
Add a new applicant including all the relevant information using the *New* button. If not already in
the Kanban view for the job position to add an applicant to, navigate to the main recruitment
dashboard by going to :menuselection:`Recruitment app --> Applications --> By Job Positions`. Then,
click the :guilabel:`New` button in the top-left of the Kanban view and a blank applicant form
loads.

Comment on lines +1049 to +1052
a red box at the bottom of the :guilabel:`Generate a Simulation Link` pop-up window, stating `The
applicant does not have a valid email set. The Offer Link won't be able to be completed.` Click
:guilabel:`Discard`, enter an email on the applicant's card, then click the :guilabel:`Generate
Offer` button again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use guilabel for text displayed on the UI

Suggested change
a red box at the bottom of the :guilabel:`Generate a Simulation Link` pop-up window, stating `The
applicant does not have a valid email set. The Offer Link won't be able to be completed.` Click
:guilabel:`Discard`, enter an email on the applicant's card, then click the :guilabel:`Generate
Offer` button again.
a red box at the bottom of the :guilabel:`Generate a Simulation Link` pop-up window, stating
:guilabel:`The applicant does not have a valid email set. The Offer Link won't be able to be
completed.` Click :guilabel:`Discard`, enter an email on the applicant's card, then click the
:guilabel:`Generate Offer` button again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants