[IMP] general: iot windows iot update process #8361

tiku-odoo · 2024-03-25T13:49:14Z

Original Task : https://www.odoo.com/web#id=3747344&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

Incremental Task:
https://www.odoo.com/web#id=3827228&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

robodoo · 2024-03-25T13:49:20Z

Pull request status dashboard.

tiku-odoo · 2024-03-25T13:56:59Z

@lse-odoo
@brse-odoo

Can you each look at this PR when you have a moment? There should only be minor changes as this copy has been rearranged for re-installation from the Windows installation page, which was recently updated.

Thanks in advance for your help on this doc!

Tim 👍

brse-odoo

@tiku-odoo I've finished my review of this PR. Great job! I only had a few suggestions for you to accept/reject as you see fit - I'm approving this PR for the next round.

Let me know if you have any questions about my comments. Thanks!

content/applications/general/iot/config/updating_iot.rst

content/applications/general/iot/config/windows_iot.rst

tiku-odoo · 2024-03-25T16:12:11Z

@wigu-odoo

Can you review these changes when you have a moment?

tiku-odoo · 2024-03-25T16:39:08Z

@ksc-odoo

This PR is ready for your review when you have a moment.

Thanks, 👍
Tim

content/applications/general/iot/config/updating_iot.rst

tiku-odoo · 2024-03-25T19:09:08Z

@ksc-odoo
Pushed up a small change on this PR (defining the link for download better).

This is a mashup of the Windows IOT doc. The focus here is upgrading (not installation).

Ready for your review when you have some time.

Thanks,
Tim

wigu-odoo

looks good on my end!

ksc-odoo

hey @tiku-odoo -- just finished my Final Review of this PR. Once you implement the necessary changes, tag me again for another quick look. Thanks! 👍

content/applications/general/iot/config/updating_iot.rst

tiku-odoo · 2024-03-26T14:05:31Z

@ksc-odoo

This doc is ready for another look!

Thanks,
Tim ,

ksc-odoo

Great work implementing the previously-suggested changes, @tiku-odoo -- there are only a handful of minor adjustments that require your attention. But, I'm going to 'approve' now, because I don't think you'll have any issues implementing them during this round of revision. Once you think it's ready, you can tag it for Tech Review. Thanks! 👍

content/applications/general/iot/config/updating_iot.rst

tiku-odoo · 2024-03-26T19:52:11Z

@samueljlieber

This doc is ready for your review when you have a moment.

Thanks,
Tim 👍

content/applications/general/iot/config/updating_iot.rst

tiku-odoo · 2024-03-27T17:30:29Z

@samueljlieber

I've added an additional admonition block to address @lse-odoo comments.

This is ready for your review now.

Thanks,
Tim

samueljlieber

Hi @tiku-odoo, nice job on this improvement PR. I have a few suggestions and corrections, please see below and my comment about the uninstallation notice.

Also, please update the commit message to have a space after the colon :)

Let me know your thoughts on the rephrasing, and tag me for another look once this PR is ready. Thank you!

content/applications/general/iot/config/updating_iot.rst

tiku-odoo · 2024-03-28T17:59:55Z

@samueljlieber

I've made the requested changes; thanks for your help streamlining it.

Ready for a final review.

Thanks,
Tim 👍

samueljlieber

Nice @tiku-odoo, thanks for implementing the suggestions from my previous review! I have just a couple more quick fixes that I will push up after this review to move this PR along. Thank you!

samueljlieber · 2024-03-28T18:19:31Z

content/applications/general/iot/config/updating_iot.rst

+
+.. important::
+   Before uninstalling a previous version of the Windows virtual :abbr:`IoT (Internet of Things)`
+   box, ensure that there is a newer version of Odoo's virtual :abbr:`IoT (Internet of Things)` box


this is referred to throughout as Windows virtual IoT box, so just changing to be consistent

Suggested change

box, ensure that there is a newer version of Odoo's virtual :abbr:`IoT (Internet of Things)` box

box, ensure that there is a newer version of Windows virtual :abbr:`IoT (Internet of Things)` box

samueljlieber · 2024-03-28T18:20:10Z

content/applications/general/iot/config/updating_iot.rst

+   --> Windows` to view the date next to the :file:`odoo_(version).latest.exe` file. *(version)* is
+   equal to the version of Odoo (e.g. 16.0, 17.0). The latest version of the Windows virtual
+   :abbr:`IoT (Internet of Things)` box can be downloaded by selecting this file, or it is always
+   available at the `Odoo Download <https://odoo.com/download/>`_ page.


Matching the UI and fixing the sentence

Suggested change

--> Windows` to view the date next to the :file:`odoo_(version).latest.exe` file. *(version)* is

equal to the version of Odoo (e.g. 16.0, 17.0). The latest version of the Windows virtual

:abbr:`IoT (Internet of Things)` box can be downloaded by selecting this file, or it is always

available at the `Odoo Download <https://odoo.com/download/>`_ page.

--> windows/` to view the date next to the :file:`odoo_(version).latest.exe` file; where

*(version)* is equal to the version of Odoo (e.g. 16.0, 17.0). The latest version of the Windows

virtual :abbr:`IoT (Internet of Things)` box can be downloaded by selecting this file, or it is

always available at the `Odoo Download <https://odoo.com/download/>`_ page.

samueljlieber · 2024-03-28T18:20:54Z

content/applications/general/iot/config/updating_iot.rst

+(stable version) --> Windows` to and select the :file:`odoo_(version).latest.exe` file. *(version)*
+is equal to the version of Odoo (e.g. 16.0, 17.0).


Matching UI and fixing sentence

Suggested change

(stable version) --> Windows` to and select the :file:`odoo_(version).latest.exe` file. *(version)*

is equal to the version of Odoo (e.g. 16.0, 17.0).

(stable version) --> windows/` to and select the :file:`odoo_(version).latest.exe` file; where

*(version)* is equal to the version of Odoo (e.g. 16.0, 17.0).

samueljlieber · 2024-03-28T18:21:25Z

content/applications/general/iot/config/updating_iot.rst

+To download from the :guilabel:`Odoo Download` page, find the :guilabel:`Odoo 16` section, or a
+version higher (depending on what version the database is), and select the :guilabel:`Download`
+button for :guilabel:`Windows`.


Can be simplified to

Suggested change

To download from the :guilabel:`Odoo Download` page, find the :guilabel:`Odoo 16` section, or a

version higher (depending on what version the database is), and select the :guilabel:`Download`

button for :guilabel:`Windows`.

To download from the :guilabel:`Odoo Download` page, find the section for the version of Odoo (e.g.

16.0, 17.0), and select the :guilabel:`Download` button for :guilabel:`Windows`.

samueljlieber

Implemented my changes in 0e09ebf, approving. Thank you @tiku-odoo 👍
..
@robodoo r+

closes #8361 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>

tiku-odoo added 16.0 17.0 labels Mar 25, 2024

tiku-odoo self-assigned this Mar 25, 2024

C3POdoo requested a review from a team March 25, 2024 13:50

tiku-odoo requested review from lse-odoo and brse-odoo March 25, 2024 14:44

brse-odoo approved these changes Mar 25, 2024

View reviewed changes

tiku-odoo requested a review from wigu-odoo March 25, 2024 16:10

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from 640d8d8 to 190b1e3 Compare March 25, 2024 16:30

tiku-odoo requested a review from ksc-odoo March 25, 2024 16:31

lse-odoo reviewed Mar 25, 2024

View reviewed changes

content/applications/general/iot/config/updating_iot.rst Outdated Show resolved Hide resolved

content/applications/general/iot/config/updating_iot.rst Show resolved Hide resolved

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch 2 times, most recently from 0e610d8 to b094039 Compare March 25, 2024 19:05

wigu-odoo approved these changes Mar 25, 2024

View reviewed changes

ksc-odoo requested changes Mar 25, 2024

View reviewed changes

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from b094039 to 6ddf0d3 Compare March 26, 2024 13:47

tiku-odoo requested a review from ksc-odoo March 26, 2024 13:48

ksc-odoo approved these changes Mar 26, 2024

View reviewed changes

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from 6ddf0d3 to 875fc98 Compare March 26, 2024 19:37

lse-odoo reviewed Mar 27, 2024

View reviewed changes

content/applications/general/iot/config/updating_iot.rst Outdated Show resolved Hide resolved

tiku-odoo requested a review from samueljlieber March 27, 2024 16:41

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from 875fc98 to 44fa6ed Compare March 27, 2024 17:25

samueljlieber requested changes Mar 28, 2024

View reviewed changes

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from 44fa6ed to 758aeca Compare March 28, 2024 17:39

tiku-odoo changed the title ~~[IMP] general:iot windows iot update process~~ [IMP] general: iot windows iot update process Mar 28, 2024

tiku-odoo requested a review from samueljlieber March 28, 2024 17:39

tiku-odoo force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from 758aeca to e3f85e6 Compare March 28, 2024 17:56

samueljlieber requested changes Mar 28, 2024

View reviewed changes

[IMP] general: iot windows iot update process

0e09ebf

samueljlieber force-pushed the 16.0-general-iot-updating-windows-iot-tiku branch from e3f85e6 to 0e09ebf Compare March 28, 2024 18:26

samueljlieber approved these changes Mar 28, 2024

View reviewed changes

robodoo pushed a commit that referenced this pull request Mar 28, 2024

[IMP] general: iot windows iot update process

e30c878

closes #8361 Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>

fw-bot mentioned this pull request Mar 28, 2024

[FW][IMP] general: iot windows iot update process #8421

Closed

robodoo temporarily deployed to merge March 28, 2024 19:43 Inactive

robodoo closed this Mar 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] general: iot windows iot update process #8361

[IMP] general: iot windows iot update process #8361

tiku-odoo commented Mar 25, 2024 •

edited

robodoo commented Mar 25, 2024

tiku-odoo commented Mar 25, 2024

brse-odoo left a comment

tiku-odoo commented Mar 25, 2024

tiku-odoo commented Mar 25, 2024

tiku-odoo commented Mar 25, 2024

wigu-odoo left a comment

ksc-odoo left a comment

tiku-odoo commented Mar 26, 2024

ksc-odoo left a comment

tiku-odoo commented Mar 26, 2024

tiku-odoo commented Mar 27, 2024

samueljlieber left a comment •

edited

tiku-odoo commented Mar 28, 2024

samueljlieber left a comment

samueljlieber Mar 28, 2024

samueljlieber Mar 28, 2024

samueljlieber Mar 28, 2024

samueljlieber Mar 28, 2024

samueljlieber left a comment

	box, ensure that there is a newer version of Odoo's virtual :abbr:`IoT (Internet of Things)` box
	box, ensure that there is a newer version of Windows virtual :abbr:`IoT (Internet of Things)` box

		(stable version) --> Windows` to and select the :file:`odoo_(version).latest.exe` file. (version)
		is equal to the version of Odoo (e.g. 16.0, 17.0).

[IMP] general: iot windows iot update process #8361

[IMP] general: iot windows iot update process #8361

Conversation

tiku-odoo commented Mar 25, 2024 • edited

robodoo commented Mar 25, 2024

tiku-odoo commented Mar 25, 2024

brse-odoo left a comment

Choose a reason for hiding this comment

tiku-odoo commented Mar 25, 2024

tiku-odoo commented Mar 25, 2024

tiku-odoo commented Mar 25, 2024

wigu-odoo left a comment

Choose a reason for hiding this comment

ksc-odoo left a comment

Choose a reason for hiding this comment

tiku-odoo commented Mar 26, 2024

ksc-odoo left a comment

Choose a reason for hiding this comment

tiku-odoo commented Mar 26, 2024

tiku-odoo commented Mar 27, 2024

samueljlieber left a comment • edited

Choose a reason for hiding this comment

tiku-odoo commented Mar 28, 2024

samueljlieber left a comment

Choose a reason for hiding this comment

samueljlieber Mar 28, 2024

Choose a reason for hiding this comment

samueljlieber Mar 28, 2024

Choose a reason for hiding this comment

samueljlieber Mar 28, 2024

Choose a reason for hiding this comment

samueljlieber Mar 28, 2024

Choose a reason for hiding this comment

samueljlieber left a comment

Choose a reason for hiding this comment

tiku-odoo commented Mar 25, 2024 •

edited

samueljlieber left a comment •

edited