New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] accounting/l10n_ec: add eCommerce section #8522
Conversation
4c2a583
to
2d841cf
Compare
Hi @rps-odoo, nice job with this improvement PR! I did a pass at the content and fixed some RST formatting in 2d841cf . This should be ready for a review :) A note for the @odoo/localizations-doc-review reviewers- this PR should be merged after #8480 so we can rebase this to include the modules added in that PR. |
2d841cf
to
bae6da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! I pushed some slight modifications, however, I could not find the SRI option on payment methods, is it already merged or is there a runbot batch where I could test this? :)
Hi, @toaa-odoo The option will only appear if you first save the payment method. If you access or create a payment method without saving first, the option will not appear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rps-odoo
Don't hesitate to reach out if you have any question ;)
@samueljlieber Let me know if anything else is needed from my side. |
bae6da6
to
6c070fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @samueljlieber !
Just three minor comments to address, so I'm already delegating the r+
@robodoo delegate=samueljlieber
6c070fe
to
795d148
Compare
TY everyone! 😄 |
Link to GDrive images folder: https://drive.google.com/drive/folders/1TRuIFiQJO5kcy11LWKDyNUuBD4sI9ZQb?usp=sharing
This PR should follow the merge of #8480