Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] accounting/l10n_ec: add eCommerce section #8522

Closed
wants to merge 1 commit into from

Conversation

rps-odoo
Copy link
Contributor

@rps-odoo rps-odoo commented Apr 3, 2024

Link to GDrive images folder: https://drive.google.com/drive/folders/1TRuIFiQJO5kcy11LWKDyNUuBD4sI9ZQb?usp=sharing

This PR should follow the merge of #8480

@robodoo
Copy link
Collaborator

robodoo commented Apr 3, 2024

@samueljlieber samueljlieber changed the title [ADD] Adding new section for eCommerce workflow [IMP] accounting/l10n_ec: add eCommerce section Apr 3, 2024
@samueljlieber samueljlieber changed the base branch from 17.0 to master April 3, 2024 21:21
@samueljlieber samueljlieber changed the base branch from master to 17.0 April 3, 2024 21:21
@C3POdoo C3POdoo requested a review from a team April 3, 2024 21:23
@samueljlieber
Copy link
Contributor

samueljlieber commented Apr 3, 2024

Hi @rps-odoo, nice job with this improvement PR! I did a pass at the content and fixed some RST formatting in 2d841cf . This should be ready for a review :)

A note for the @odoo/localizations-doc-review reviewers- this PR should be merged after #8480 so we can rebase this to include the modules added in that PR.

Copy link
Contributor

@toaa-odoo toaa-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! I pushed some slight modifications, however, I could not find the SRI option on payment methods, is it already merged or is there a runbot batch where I could test this? :)

@rps-odoo
Copy link
Contributor Author

rps-odoo commented Apr 5, 2024

Thanks for the work! I pushed some slight modifications, however, I could not find the SRI option on payment methods, is it already merged or is there a runbot batch where I could test this? :)

Hi, @toaa-odoo The option will only appear if you first save the payment method. If you access or create a payment method without saving first, the option will not appear.

@toaa-odoo toaa-odoo requested a review from a team April 9, 2024 14:08
@xpl-odoo xpl-odoo requested review from xpl-odoo and removed request for a team April 18, 2024 07:00
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rps-odoo
Don't hesitate to reach out if you have any question ;)

@rps-odoo
Copy link
Contributor Author

@samueljlieber Let me know if anything else is needed from my side.

@samueljlieber
Copy link
Contributor

Hi @xpl-odoo and @rps-odoo, thank you for the review. I implemented the suggestions in 6c070fe :)

Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samueljlieber !
Just three minor comments to address, so I'm already delegating the r+
@robodoo delegate=samueljlieber

@samueljlieber
Copy link
Contributor

TY everyone! 😄
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants