Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] productivity: calendar google error troubleshooting #8643

Conversation

@tiku-odoo tiku-odoo self-assigned this Apr 10, 2024
@C3POdoo C3POdoo requested a review from a team April 10, 2024 17:02
@robodoo
Copy link
Collaborator

robodoo commented Apr 10, 2024

@tiku-odoo
Copy link
Contributor Author

@jevs-odoo

When you have a moment, can you look at the changes in this doc? I've added Google FAQ. Thanks, Tim

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-google-error-troubleshooting-tiku branch from 786c9c4 to 61e4e8a Compare April 10, 2024 17:44
@tiku-odoo
Copy link
Contributor Author

@brse-odoo

This doc is ready for your review:

Lines
157-208

This section was taken from the Google gmail doc: https://www.odoo.com/documentation/15.0/applications/general/email_communication/google_oauth.html#google-oauth-faq

I added the last admonition block to the web-based URL.

Thanks for your review!

Tim 👍

Copy link
Contributor

@brse-odoo brse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiku-odoo I've finished my review of the lines in this doc requested for review - nice job. I am approving with a few comments for you to accept/reject as you see fit. Let me know if you have any questions, thanks!

content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-google-error-troubleshooting-tiku branch from 61e4e8a to dd56ee1 Compare April 11, 2024 13:39
@tiku-odoo tiku-odoo requested a review from ksc-odoo April 11, 2024 13:43
@tiku-odoo
Copy link
Contributor Author

@ksc-odoo

This doc change is ready for your review:

Lines: 157-212

Thanks,
Tim

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiku-odoo -- just finished my Final Review of this PR! Only have a few suggestions that require your attention. Approving now. 👍 Once you've made the necessary adjustments, feel free to tag this for Tech Review! Thanks! 👍

content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-google-error-troubleshooting-tiku branch from dd56ee1 to c07636d Compare April 12, 2024 20:40
@tiku-odoo
Copy link
Contributor Author

@StraubCreative

This PR is ready for your technical review when you have a moment.

Thanks,
Tim

@samueljlieber samueljlieber requested a review from a team April 18, 2024 16:47
@tiku-odoo
Copy link
Contributor Author

@odoo/us-doc-review
This doc is ready for your tech review.

Thanks, Tim

@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-google-error-troubleshooting-tiku branch from c07636d to 40aac86 Compare April 18, 2024 16:57
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tiku-odoo, nice job on the FAQ content being added to this doc. This PR is looking great, I just have a few small comments, please see below. Tag me for one more quick look once these are addressed and I will get this PR moving along! Thank you 🙏

content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
content/applications/productivity/calendar/google.rst Outdated Show resolved Hide resolved
@tiku-odoo tiku-odoo force-pushed the 15.0-productivity-calendar-google-error-troubleshooting-tiku branch from 40aac86 to 77da6f9 Compare April 18, 2024 17:40
@tiku-odoo
Copy link
Contributor Author

@samueljlieber

This doc is ready for another look when you have a moment. All images have been cropped.

Thanks, 👍
Tim

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @tiku-odoo, looks good to me. Thank you for cropping the images, they look great 👍
..
@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 18, 2024
closes #8643

Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants