Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] inventory: update cycle counts doc #8858

Closed
wants to merge 1 commit into from
Closed

[IMP] inventory: update cycle counts doc #8858

wants to merge 1 commit into from

Conversation

brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented Apr 18, 2024 •
edited

This PR is an [IMP] targeting the cycle_counts doc in Odoo's Inventory app documentation, specific to 17.0.

Here's what I did:

  • Rewrote/updated copy and sections for accuracy specific to 17.0
  • Replaced all screenshots with 17.0 UI

Project Task Link

@brse-odoo brse-odoo self-assigned this Apr 18, 2024
@C3POdoo C3POdoo requested a review from a team April 18, 2024 20:24
@robodoo
Copy link
Collaborator

robodoo commented Apr 18, 2024

Pull request status dashboard.

@brse-odoo
Copy link
Contributor Author

Hi @odoo/inventory-doc-review, this PR is ready for content review when one of you has a chance. Thanks!

Felicious
Felicious approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, @brse-odoo! Everything works as expected in my testing.

I just had minor wording suggestions, so feel free to implement what you like, and tag the next reviewer!

...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
@brse-odoo brse-odoo force-pushed the 17.0-inventory-update-cycle-counts-brse branch from 470aacf to b6de682 Compare April 22, 2024 14:20
@brse-odoo
Copy link
Contributor Author

Alright @odoo/us-doc-review, this PR is ready for the final content review, thank you!

@brse-odoo brse-odoo requested a review from a team April 22, 2024 14:27
@brse-odoo brse-odoo changed the base branch from 17.0 to 16.0 April 22, 2024 14:32
@brse-odoo brse-odoo changed the base branch from 16.0 to 17.0 April 22, 2024 14:32
ksc-odoo
ksc-odoo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brse-odoo -- just finished my Final Review on this! Great work. Approving now! There is only a small handful of suggestions that require your attention. So, once those necessary changes have been implemented, you can feel free to tag this for Tech Review. Thanks! 👍

...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
...cations/inventory_and_mrp/inventory/warehouses_storage/inventory_management/cycle_counts.rst Outdated Show resolved Hide resolved
@brse-odoo brse-odoo force-pushed the 17.0-inventory-update-cycle-counts-brse branch from b6de682 to 6e138c6 Compare April 22, 2024 19:01
@brse-odoo
Copy link
Contributor Author

@samueljlieber This PR is ready for tech review when you have a chance, thank you!

@brse-odoo brse-odoo requested a review from a team April 22, 2024 19:05
samueljlieber
samueljlieber approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @brse-odoo, nice PR! Thank you
...
@robodoo r+

@robodoo robodoo closed this in 0456d10 Apr 23, 2024
@fw-bot fw-bot mentioned this pull request Apr 23, 2024
Closed
This was referenced Apr 23, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felicious Felicious Felicious approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Assignees

@brse-odoo brse-odoo

Labels
3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brse-odoo @robodoo @Felicious @samueljlieber @ksc-odoo