Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][ADD] extensions: icon_role font awesome #9060

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Apr 29, 2024

Task: #3843168

This PR adds a custom extension for an :icon: role to allow the use of Font Awesome icons in documentation.

With the new role, icons can be called by their classname.

This is a Font Awesome :icon:`fa-step-forward` icon.
Screenshot 2024-04-02 at 11 07 01 AM

If this PR is approved, it will likely need to be manually forward ported to each version.

Forward-Port-Of: #9053
Forward-Port-Of: #8469

@robodoo
Copy link
Collaborator

robodoo commented Apr 29, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 29, 2024

This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 29, 2024

@samueljlieber ci/documentation failed on this forward-port PR

@samueljlieber samueljlieber force-pushed the saas-17.2-15.0-extensions-icons-sali-yB0a-fw branch from 3214ce2 to b9e4024 Compare April 29, 2024 20:14
@fw-bot
Copy link
Collaborator Author

fw-bot commented Apr 29, 2024

@samueljlieber this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

@samueljlieber
Copy link
Contributor

b9e4024 Rebased to latest to resolve build error

@C3POdoo C3POdoo requested review from a team April 29, 2024 20:16
@samueljlieber
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 29, 2024
closes #9060

X-original-commit: 8bec283
Signed-off-by: Samuel Lieber (sali) <sali@odoo.com>
@robodoo robodoo closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants