Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] inventory: moves history report #9343

Closed
wants to merge 1 commit into from
Closed

[ADD] inventory: moves history report #9343

wants to merge 1 commit into from

Conversation

Felicious
Copy link
Contributor

@Felicious Felicious commented May 15, 2024 •
edited

Overview of the Stock Moves report.

  1. Include info about the columns and fields
  2. Include overview of filters and group bys.
  3. Imply its link to the inventory adjustments page

Task

@robodoo
Copy link
Collaborator

robodoo commented May 15, 2024

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team May 15, 2024 04:12
@Felicious Felicious force-pushed the 17.0-inventory-moves-history-feku branch from 04f4ff6 to 8c74da3 Compare May 15, 2024 04:14
@Felicious Felicious requested a review from brse-odoo May 15, 2024 04:23
@Felicious Felicious self-assigned this May 15, 2024
@Felicious Felicious added the 5 label May 15, 2024
brse-odoo
brse-odoo approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@brse-odoo brse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious, I've finished my review of this PR, great job! I'm approving with very few suggestions. My only other recommendation (not totally necessary, just a "nice to have") would be to include an additional image of the search menu options - filter/group by and all that.

Let me know if you have any questions, thanks!

content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
@Felicious Felicious force-pushed the 17.0-inventory-moves-history-feku branch 2 times, most recently from a6bd186 to 14a233d Compare May 16, 2024 21:31
@Felicious Felicious requested a review from a team May 16, 2024 21:42
StraubCreative
StraubCreative approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious

Another good start to building out the inventory reporting documentation!

I had two items for you below: one is a detailed response to the title question being entertained from peer review (lmk if you have feedback/questions there), and the other is just a small markup suggestion 😄

I think for the content, though, we're good to go and can tag @samueljlieber when you're ready for a tech review.

Cheers!

content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
@Felicious Felicious force-pushed the 17.0-inventory-moves-history-feku branch from fb8df31 to 6e6ff8e Compare May 17, 2024 14:45
@Felicious
Copy link
Contributor Author

Hello @samueljlieber ! This PR is ready for tech review (:

samueljlieber
samueljlieber approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious, great job on this brand new Inventory doc! Your PR looks great to me, I have a couple suggestions I am approving with. Thanks for your hard work! 👍
.....
@robodoo delegate=Felicious

content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Outdated Show resolved Hide resolved
content/applications/inventory_and_mrp/inventory/warehouses_storage/reporting/moves_history.rst Show resolved Hide resolved
@Felicious @brse-odoo
@StraubCreative @samueljlieber
[ADD] inventory: moves history report
ad5f282 
Co-authored-by: brse-odoo <brse@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@Felicious Felicious force-pushed the 17.0-inventory-moves-history-feku branch from 0904ea3 to ad5f282 Compare May 17, 2024 22:41
@Felicious
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request May 18, 2024
@Felicious @brse-odoo
@StraubCreative @samueljlieber
[ADD] inventory: moves history report
07c4a45 
closes #9343

Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
Co-authored-by: brse-odoo <brse@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@robodoo
Copy link
Collaborator

robodoo commented May 18, 2024

@Felicious staging failed: ci/runbot on fc041bca6bc7910b2ee2570332fd8def4d0afa35 (view more at https://runbot.odoo.com/runbot/build/62703503)

@StraubCreative
Copy link
Contributor

@robodoo retry

@robodoo robodoo closed this in 6920015 May 20, 2024
This was referenced May 20, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

@brse-odoo brse-odoo brse-odoo approved these changes

Assignees

@Felicious Felicious

Labels
5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Felicious @robodoo @StraubCreative @samueljlieber @brse-odoo